commit 1afe00c0e4eef5170beba7bfe99106a5297b5460
author roldenburg <roldenburg@google.com> Fri Oct 13 15:31:54 2017 -0700
committer Eric Erfanian <erfanian@google.com> Fri Oct 13 15:43:24 2017 -0700
tree f9f525549155f28b9751bbdd4cbff45e730d910a
parent b78f03c0f1f5be3303e900272d9c7d243628a37b

Do not load every DialtactsActivity fragment on app open

With this change we now only load the Favorites and Call Log Fragments when the
app opens.

Paging to the CallLogFragment makes the ContactsFragment load as we would want.

This should result in a faster app start time. I'll need to verify the impact
of this using the same method as http://cl/170422671

I verified the change in behavior by adding my own log line to the onCreate of each Fragment. I saw all of them get created before the change, and only the expected 2 with this change.

Bug: 64541209,65460373
Test: manual
PiperOrigin-RevId: 172154863
Change-Id: Iaf6e217df284e6df6f13688ac6aa677481a575e0

java/com/android/dialer/app/list/ListsFragment.java

diff --git a/java/com/android/dialer/app/list/ListsFragment.java b/java/com/android/dialer/app/list/ListsFragment.java
index 362997a..05c647a 100644
--- a/java/com/android/dialer/app/list/ListsFragment.java
+++ b/java/com/android/dialer/app/list/ListsFragment.java
@@ -203,7 +203,11 @@
             mPrefs.getBoolean(
                 VisualVoicemailEnabledChecker.PREF_KEY_HAS_ACTIVE_VOICEMAIL_PROVIDER, false));
     mViewPager.setAdapter(mAdapter);
-    mViewPager.setOffscreenPageLimit(DialtactsPagerAdapter.TAB_COUNT_WITH_VOICEMAIL - 1);
+
+    // This is deliberate. See cl/172018946 for the app startup implications of using 1 here
+    // versus loading more fragments upfront.
+    mViewPager.setOffscreenPageLimit(1);
+
     mViewPager.addOnPageChangeListener(this);
     showTab(DialtactsPagerAdapter.TAB_INDEX_SPEED_DIAL);