commit 6a8de737e8ccb21647adb56d3e5248595f85436d
author Ta-wei Yen <twyen@google.com> Wed Nov 04 02:52:22 2015 +0000
committer Android (Google) Code Review <android-gerrit@google.com> Wed Nov 04 02:52:22 2015 +0000
tree 56b8a7896295f452730774fe1c82b4e11d0c0a53
parent 26072c733ba61f6cbbdfb40808fb6a700af8e1f7
parent e3cae63fc19a431d902fb8ae50eab732e735b2a0

Merge "DiatactsActivity title indicate dialpad status, removed excessive "showing item" messages." into ub-contactsdialer-a-dev

src/com/android/dialer/CallDetailActivity.java

diff --git a/src/com/android/dialer/CallDetailActivity.java b/src/com/android/dialer/CallDetailActivity.java
index ab63ddc..0d943e0 100644
--- a/src/com/android/dialer/CallDetailActivity.java
+++ b/src/com/android/dialer/CallDetailActivity.java
@@ -161,7 +161,8 @@
             mHistoryList.setAdapter(
                     new CallDetailHistoryAdapter(mContext, mInflater, mCallTypeHelper, details));
 
-            updatePhotoAndBlockActionItem();
+            updateFilteredNumberChanges();
+            updateContactPhoto();
 
             findViewById(R.id.call_detail).setVisibility(View.VISIBLE);
         }
@@ -380,15 +381,15 @@
 
     @Override
     public void onChangeFilteredNumberSuccess() {
-        updatePhotoAndBlockActionItem();
+        updateFilteredNumberChanges();
     }
 
     @Override
     public void onChangeFilteredNumberUndo() {
-        updatePhotoAndBlockActionItem();
+        updateFilteredNumberChanges();
     }
 
-    private void updatePhotoAndBlockActionItem() {
+    private void updateFilteredNumberChanges() {
         if (mDetails == null ||
                 !FilteredNumbersUtil.canBlockNumber(this, mNumber, mDetails.countryIso)) {
             return;
@@ -399,14 +400,11 @@
                     @Override
                     public void onCheckComplete(Integer id) {
                         mBlockedNumberId = id;
-
-                        updateContactPhoto();
                         updateBlockActionItem();
                     }
                 }, mNumber, mDetails.countryIso);
 
         if (!success) {
-            updateContactPhoto();
             updateBlockActionItem();
         }
     }
@@ -417,11 +415,6 @@
             return;
         }
 
-        if (mBlockedNumberId != null) {
-            mQuickContactBadge.setImageDrawable(mContext.getDrawable(R.drawable.blocked_contact));
-            return;
-        }
-
         final boolean isVoicemailNumber =
                 PhoneNumberUtil.isVoicemailNumber(mContext, mDetails.accountHandle, mNumber);
         final boolean isBusiness = mContactInfoHelper.isBusiness(mDetails.sourceType);

src/com/android/dialer/list/PhoneFavoritesTileAdapter.java

diff --git a/src/com/android/dialer/list/PhoneFavoritesTileAdapter.java b/src/com/android/dialer/list/PhoneFavoritesTileAdapter.java
index cd4c10b..77da7e9 100644
--- a/src/com/android/dialer/list/PhoneFavoritesTileAdapter.java
+++ b/src/com/android/dialer/list/PhoneFavoritesTileAdapter.java
@@ -192,7 +192,7 @@
         mPhoneNumberTypeIndex = ContactTileLoaderFactory.PHONE_NUMBER_TYPE;
         mPhoneNumberLabelIndex = ContactTileLoaderFactory.PHONE_NUMBER_LABEL;
         mPinnedIndex = ContactTileLoaderFactory.PINNED;
-        mContactIdIndex = ContactTileLoaderFactory.CONTACT_ID;
+        mContactIdIndex = ContactTileLoaderFactory.CONTACT_ID_FOR_DATA;
 
 
         mPresenceIndex = ContactTileLoaderFactory.CONTACT_PRESENCE;