commit c377217d3ebd503fb91c55ac871c981f99ec649c
author zachh <zachh@google.com> Mon Jan 29 15:35:05 2018 -0800
committer Copybara-Service <copybara-piper@google.com> Mon Jan 29 20:49:58 2018 -0800
tree d36ab22603eb32f173c5ed6ac8666c4f65b2aeba
parent f27f1bd028abfcac714cf5aed6bbbab8d21077a6

Use application context when fetching shared prefs.

Using non-application contexts incurs extra disk access because shared prefs are cached per context.

Test: manually ejected sim and observed no strict mode violations
PiperOrigin-RevId: 183739285
Change-Id: I9337e226ae1e060478219cf495752ceccf5a31e6

java/com/android/voicemail/impl/OmtpService.java

diff --git a/java/com/android/voicemail/impl/OmtpService.java b/java/com/android/voicemail/impl/OmtpService.java
index 4e8860c..e10a275 100644
--- a/java/com/android/voicemail/impl/OmtpService.java
+++ b/java/com/android/voicemail/impl/OmtpService.java
@@ -197,14 +197,14 @@
   }
 
   private static void setShuttingDown(Context context, boolean value) {
-    PreferenceManager.getDefaultSharedPreferences(context)
+    PreferenceManager.getDefaultSharedPreferences(context.getApplicationContext())
         .edit()
         .putBoolean(IS_SHUTTING_DOWN, value)
         .apply();
   }
 
   private static boolean isShuttingDown(Context context) {
-    return PreferenceManager.getDefaultSharedPreferences(context)
+    return PreferenceManager.getDefaultSharedPreferences(context.getApplicationContext())
         .getBoolean(IS_SHUTTING_DOWN, false);
   }
 }

java/com/android/voicemail/impl/VisualVoicemailPreferences.java

diff --git a/java/com/android/voicemail/impl/VisualVoicemailPreferences.java b/java/com/android/voicemail/impl/VisualVoicemailPreferences.java
index 72506eb..1d7204e 100644
--- a/java/com/android/voicemail/impl/VisualVoicemailPreferences.java
+++ b/java/com/android/voicemail/impl/VisualVoicemailPreferences.java
@@ -31,7 +31,7 @@
     super(
         context,
         phoneAccountHandle,
-        PreferenceManager.getDefaultSharedPreferences(context),
+        PreferenceManager.getDefaultSharedPreferences(context.getApplicationContext()),
         "visual_voicemail_");
   }
 }