commit e5b24ecbe50bd79d2ce7ad8a284ac17ad1284d83
author Sailesh Nepal <sail@google.com> Wed Jun 01 10:57:44 2016 -0700
committer Sailesh Nepal <sail@google.com> Wed Jun 01 11:31:27 2016 -0700
tree 4af163b950c4040833bcaecfbe029ffa4598c69d
parent af55d40c0d45b47ace8bc161e99f13da50faa8a0

Fix missed call notification dialing wrong number

This CL fixes a bug where clicking the "callback" button on the missed
call notification would dial the previous missed call.

To reproduce the bug you had to do the following:
    - get a missed call from Party A
    - clear the missed call count by launching dialer and navigating to
      the call log then pressing home. Clearing the missed call count by
      swipping away the notification should also work.
    - get a missed call from Party B
    - click "callback" on the new missed call notification Previously
      this would result in Party A getting called back.

The problem was that we were using the wrong pending intent flags:
- Flag 0: before ag/925201 we were using 0 which meant that the pending
  intent with Party A was being used.
- FLAG_ONE_SHOT: after ag/925201 we were using FLAG_ONE_SHOT which
  meant that the pending intent would be cancelled after the first use
  (after the user clicked callback on Party A). If the user never
  clicked callback on Party A then the intent would be re-used.

Fix was to use FLAG_UPDATE_CURRENT instead. This ensured that the
pending intent was always updated with the last missed call number.

Bug: 29065901
Change-Id: I8515e82d178348235d775b7a110e662652b3385b

src/com/android/dialer/calllog/MissedCallNotifier.java

diff --git a/src/com/android/dialer/calllog/MissedCallNotifier.java b/src/com/android/dialer/calllog/MissedCallNotifier.java
index 3afc112..a879c6f 100644
--- a/src/com/android/dialer/calllog/MissedCallNotifier.java
+++ b/src/com/android/dialer/calllog/MissedCallNotifier.java
@@ -255,8 +255,9 @@
         intent.setAction(
                 CallLogNotificationsService.ACTION_CALL_BACK_FROM_MISSED_CALL_NOTIFICATION);
         intent.putExtra(CallLogNotificationsService.EXTRA_MISSED_CALL_NUMBER, number);
-        // Use FLAG_ONE_SHOT to avoid reusing previous PendingIntent with different number.
-        return PendingIntent.getService(mContext, 0, intent, PendingIntent.FLAG_ONE_SHOT);
+        // Use FLAG_UPDATE_CURRENT to make sure any previous pending intent is updated with the new
+        // extra.
+        return PendingIntent.getService(mContext, 0, intent, PendingIntent.FLAG_UPDATE_CURRENT);
     }
 
     private PendingIntent createSendSmsFromNotificationPendingIntent(String number) {
@@ -264,8 +265,9 @@
         intent.setAction(
                 CallLogNotificationsService.ACTION_SEND_SMS_FROM_MISSED_CALL_NOTIFICATION);
         intent.putExtra(CallLogNotificationsService.EXTRA_MISSED_CALL_NUMBER, number);
-        // Use FLAG_ONE_SHOT to avoid reusing previous PendingIntent with different number.
-        return PendingIntent.getService(mContext, 0, intent, PendingIntent.FLAG_ONE_SHOT);
+        // Use FLAG_UPDATE_CURRENT to make sure any previous pending intent is updated with the new
+        // extra.
+        return PendingIntent.getService(mContext, 0, intent, PendingIntent.FLAG_UPDATE_CURRENT);
     }
 
     /**