commit e7b2801cda823c63322b3291021677acfb8d33ef
author Makoto Onuki <omakoto@google.com> Thu Sep 20 16:48:56 2012 -0700
committer Makoto Onuki <omakoto@google.com> Fri Sep 21 10:57:49 2012 -0700
tree 4182ac957ea5c46ae924b7bea7f8f4f152e3ba45
parent a1593e6ed73bd928594929ea40dbe6c84fc0d4b6

[cherrypick] Fix potential issue in I3d791ce1f536680a9ca0db2c387f3aad36eda17f

Bug 7164046

Change-Id: Ic03bd6151ba5ee91287b248fe295614aa816f25b

src/com/android/dialer/calllog/CallLogFragment.java

diff --git a/src/com/android/dialer/calllog/CallLogFragment.java b/src/com/android/dialer/calllog/CallLogFragment.java
index a59be85..af32ef8 100644
--- a/src/com/android/dialer/calllog/CallLogFragment.java
+++ b/src/com/android/dialer/calllog/CallLogFragment.java
@@ -546,15 +546,27 @@
      * Register a phone call filter to reset the call type when a phone call is place.
      */
     private void registerPhoneCallReceiver() {
+        if (mPhoneStateListener != null) {
+            return; // Already registered.
+        }
         mTelephonyManager = (TelephonyManager) getActivity().getSystemService(
                 Context.TELEPHONY_SERVICE);
         mPhoneStateListener = new PhoneStateListener() {
             @Override
             public void onCallStateChanged(int state, String incomingNumber) {
-                if (state == TelephonyManager.CALL_STATE_OFFHOOK ||
-                        state == TelephonyManager.CALL_STATE_RINGING) {
-                    updateFilterTypeAndHeader(CallLogQueryHandler.CALL_TYPE_ALL);
+                if (state != TelephonyManager.CALL_STATE_OFFHOOK &&
+                        state != TelephonyManager.CALL_STATE_RINGING) {
+                    return;
                 }
+                mHandler.post(new Runnable() {
+                    @Override
+                    public void run() {
+                        if (getActivity() == null || getActivity().isFinishing()) {
+                            return;
+                        }
+                        updateFilterTypeAndHeader(CallLogQueryHandler.CALL_TYPE_ALL);
+                    }
+                 });
             }
         };
         mTelephonyManager.listen(mPhoneStateListener, PhoneStateListener.LISTEN_CALL_STATE);
@@ -566,6 +578,7 @@
     private void unregisterPhoneCallReceiver() {
         if (mPhoneStateListener != null) {
             mTelephonyManager.listen(mPhoneStateListener, PhoneStateListener.LISTEN_NONE);
+            mPhoneStateListener = null;
         }
     }
 }