Gitiles
Code Review Sign In
review.blissroms.org / platform_packages_modules_Bluetooth / 3713e8afee104e864e77726dfeb1a8b159cd936f
commit3713e8afee104e864e77726dfeb1a8b159cd936f[log] [tgz]
authorEtienne Ruffieux <eruffieux@google.com>Wed Jul 10 11:50:25 2024 +0000
committerEtienne Ruffieux <eruffieux@google.com>Fri Aug 09 15:38:11 2024 +0000
treed1bca8f9b28f0e81da875f9e890caeb8eb8108fa
parent551dc422f01f75ca8d45e866248e296d0270dbf5 [diff]
Implement AVRCP's set addressed player

This implements SetAddressedPlayer properly now that we
have an utility for it (since the browsing refactor).

Android's MediaSessions doesn't allow to set an active
session from its controller, hence we can't set the
session as active with SetAddressedPlayer and we need to
keep the "active", "browsed" and add an "addressed" session
id.
The "active" session corresponds to the session registered
to Android media key events - the session Android Media
considers as active.
The "browsed" session is the one the remote is currently
browsing. Can be any players and isn't linked to the
"active" session.

The "addressed" session is the session the remote whishes
to control. Once a play event is received form the CT, we
check if there is an "addressed" session and proceed to
send the play event to it instead of just sending it to the
active session. This will in turn modify the "active"
session to become the addressed one.
If the active session is changed directly on TG, then the
"addressed" session will change to it and TG will notify CT

As of now, controls other than PLAY will still be sent to
the "active" session. For two reasons:
- We don't have a way to make the "addressed" session
active in Android Media, so the previous session will
continue to play and we want to be able to control it.
This fits the section 29.15 from AVRCP 1.6.2 spec.
- Sending MEDIA_NEXT to a non active session wouldn't do
anything.

Bug: 346717077
Flag: com.android.bluetooth.flags.set_addressed_player
Test: atest pts-bot:AVRCP
Change-Id: I6dae8ead88195abd7a73230793e1df8d02501d6f
13 files changed
tree: d1bca8f9b28f0e81da875f9e890caeb8eb8108fa
  1. android/
  2. apex/
  3. flags/
  4. floss/
  5. framework/
  6. pandora/
  7. service/
  8. sysprop/
  9. system/
  10. tools/
  11. .clang-format
  12. .editorconfig
  13. .gitignore
  14. .style.yapf
  15. Android.bp
  16. AndroidTestTemplate.xml
  17. BUILD.gn
  18. build.py
  19. Cargo.toml
  20. checkstyle.xml
  21. checkstyle_suppressions.xml
  22. CPPLINT.cfg
  23. METADATA
  24. MODULE_LICENSE_APACHE2
  25. NOTICE
  26. OWNERS
  27. OWNERS_automotive
  28. OWNERS_build
  29. OWNERS_chromeos
  30. OWNERS_content
  31. OWNERS_cs
  32. OWNERS_hearingaid
  33. OWNERS_leaudio
  34. PREUPLOAD.cfg
  35. README.md
  36. rustfmt.toml
  37. TEST_MAPPING
README.md

Fluoride Bluetooth stack

Building and running on AOSP

Just build AOSP - Fluoride is there by default.

Building and running on Linux

Instructions for a Debian based distribution:

  • Debian Bullseye or newer
  • Ubuntu 20.10 or newer
  • Clang-11 or Clang-12
  • Flex 2.6.x
  • Bison 3.x.x (tested with 3.0.x, 3.2.x and 3.7.x)

You'll want to download some pre-requisite packages as well. If you're currently configured for AOSP development, you should have most required packages. Otherwise, you can use the following apt-get list or use the --run-bootstrap option on build.py (see below) to get a list of packages missing on your system:

sudo apt-get install repo git-core gnupg flex bison gperf build-essential \
  zip curl zlib1g-dev gcc-multilib g++-multilib \
  x11proto-core-dev libx11-dev libncurses5 \
  libgl1-mesa-dev libxml2-utils xsltproc unzip liblz4-tool libssl-dev \
  libc++-dev libevent-dev \
  flatbuffers-compiler libflatbuffers1 openssl \
  libflatbuffers-dev libfmt-dev libtinyxml2-dev \
  libglib2.0-dev libevent-dev libnss3-dev libdbus-1-dev \
  libprotobuf-dev ninja-build generate-ninja protobuf-compiler \
  libre2-9 debmake \
  llvm libc++abi-dev \
  libre2-dev libdouble-conversion-dev \
  libgtest-dev libgmock-dev libabsl-dev

You will also need a recent-ish version of Rust and Cargo. Please follow the instructions on Rustup to install a recent version.

Download source

mkdir ~/fluoride
cd ~/fluoride
git clone https://android.googlesource.com/platform/packages/modules/Bluetooth

Using --run-bootstrap on build.py

build.py is the helper script used to build Fluoride for Linux (i.e. Floss). It accepts a --run-bootstrap option that will set up your build staging directory and also make sure you have all required system packages to build (should work on Debian and Ubuntu). You will still need to build some unpackaged dependencies (like libchrome, modp_b64, googletest, etc).

To use it:

./build.py --run-bootstrap

This will install your bootstrapped build environment to ~/.floss. If you want to change this, just pass in --bootstrap-dir to the script.

Build dependencies

The following third-party dependencies are necessary but currently unavailable via a package manager. You may have to build these from source and install them to your local environment.

  • libchrome
  • modp_b64

We provide a script to produce debian packages for those components. Please see the instructions in build/dpkg/README.txt for more details.

cd system/build/dpkg
mkdir -p outdir/{modp_b64,libchrome}

# Build and install modp_b64
pushd modp_b64
./gen-src-pkg.sh $(readlink -f ../outdir/modp_b64)
popd
sudo dpkg -i outdir/modp_b64/*.deb

# Build and install libchrome
pushd libchrome
./gen-src-pkg.sh $(readlink -f ../outdir/libchrome)
popd
sudo dpkg -i outdir/libchrome/*.deb

Rust dependencies

Note: Handled by --run-bootstrap option.

Run the following to install Rust dependencies:

cargo install cxxbridge-cmd

Stage your build environment

Note: Handled by --run-bootstrap option.

For host build, we depend on a few other repositories:

Clone these all somewhere and create your staging environment.

export STAGING_DIR=path/to/your/staging/dir
mkdir ${STAGING_DIR}
mkdir -p ${STAGING_DIR}/external
ln -s $(readlink -f ${PLATFORM2_DIR}/common-mk) ${STAGING_DIR}/common-mk
ln -s $(readlink -f ${PLATFORM2_DIR}/.gn) ${STAGING_DIR}/.gn
ln -s $(readlink -f ${RUST_CRATE_DIR}) ${STAGING_DIR}/external/rust
ln -s $(readlink -f ${PROTO_LOG_DIR}) ${STAGING_DIR}/external/proto_logging

Build

We provide a build script to automate building assuming you've staged your build environment already as above. At this point, make sure you have all the pre-requisites installed (i.e. bootstrap option and other dependencies above) or you will see failures. In addition, you may need to set a --libdir= if your libraries are not stored in /usr/lib by default.

./build.py

This will build all targets to the output directory at --bootstrap-dir (which defaults to ~/.floss). You can also build each stage separately (if you want to iterate on something specific):

  • prepare - Generate the GN rules
  • tools - Generate host tools
  • rust - Build the rust portion of the build
  • main - Build all the C/C++ code
  • test - Build all targets and run the tests
  • clean - Clean the output directory

You can choose to run only a specific stage by passing an arg via --target.

Currently, Rust builds are a separate stage that uses Cargo to build. See gd/rust/README.md for more information. If you are iterating on Rust code and want to add new crates, you may also want to use the --no-vendored-rust option (which will let you use crates.io instead of using a pre-populated vendored crates repo).

Run

By default on Linux, we statically link libbluetooth so you can just run the binary directly. By default, it will try to run on hci0 but you can pass it --hci=N, where N corresponds to /sys/class/bluetooth/hciN.

$OUTPUT_DIR/debug/btadapterd --hci=$HCI INIT_gd_hci=true