| commit | de2ba72b19564873898638b99ebd391aa1cbff2f | [log] [tgz] |
|---|---|---|
| author | Cheney Ni <cheneyni@google.com> | Thu Nov 21 02:49:12 2019 +0800 |
| committer | Cheney Ni <cheneyni@google.com> | Fri Nov 22 17:05:53 2019 +0800 |
| tree | ad48ed8f49b415de1c6ac9f3ffc81d2e3a41330e | |
| parent | 7d6b5acef279a1d533e3c6e548493ae490633445 [diff] |
A2DP: Do AV suspend / stop at the stack main thread Because Bluetooth stack cleaned up peers at its main thread, there would be a race condition if audio HAL asked to suspend / stop the stream at the same time. These tasks were handled by the called-in thread like HwBinder, and was segmentation fault since peers were cleaned. This CL moves audio control tasks to the stack main thread to prevent it. Besides, this CL also modified the check of audio HAL A2DP CMDs: * A2DP_Start should be successful if streaming already, and is because we only have this HAL as our input. It did not make scense to have streaming without a provider. * A2DP_Stop should not check whether the media tick was scheduled or not for a hardware offloading case. Bug: 139646747 Bug: 144067743 Test: A2DP playback Change-Id: I736b308628b0da75ceb91e57cfe1854c6767233d
Just build AOSP - Fluoride is there by default.
Instructions for Ubuntu, tested on 14.04 with Clang 3.5.0 and 16.10 with Clang 3.8.0
mkdir ~/fluoride cd ~/fluoride git clone https://android.googlesource.com/platform/packages/modules/Bluetooth/system
Install dependencies (require sudo access):
cd ~/fluoride/bt build/install_deps.sh
Then fetch third party dependencies:
cd ~/fluoride/bt mkdir third_party cd third_party git clone https://github.com/google/googletest.git git clone https://android.googlesource.com/platform/external/aac git clone https://android.googlesource.com/platform/external/libchrome git clone https://android.googlesource.com/platform/external/libldac git clone https://android.googlesource.com/platform/external/modp_b64 git clone https://android.googlesource.com/platform/external/tinyxml2
And third party dependencies of third party dependencies:
cd fluoride/bt/third_party/libchrome/base/third_party mkdir valgrind cd valgrind curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/valgrind.h?format=TEXT | base64 -d > valgrind.h curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/memcheck.h?format=TEXT | base64 -d > memcheck.h
NOTE: If packages/modules/Bluetooth/system is checked out under AOSP, then create symbolic links instead of downloading sources
cd packages/modules/Bluetooth/system mkdir third_party cd third_party ln -s ../../../external/aac aac ln -s ../../../external/libchrome libchrome ln -s ../../../external/libldac libldac ln -s ../../../external/modp_b64 modp_b64 ln -s ../../../external/tinyxml2 tinyxml2 ln -s ../../../external/googletest googletest
cd ~/fluoride/bt gn gen out/Default
cd ~/fluoride/bt ninja -C out/Default all
This will build all targets (the shared library, executables, tests, etc) and put them in out/Default. To build an individual target, replace "all" with the target of your choice, e.g. ninja -C out/Default net_test_osi.
cd ~/fluoride/bt/out/Default LD_LIBRARY_PATH=./ ./bluetoothtbd -create-ipc-socket=fluoride
Follows the Chromium project Eclipse Setup Instructions until "Optional: Building inside Eclipse" section (don't do that section, we will set it up differently)
Generate Eclipse settings:
cd packages/modules/Bluetooth/system gn gen --ide=eclipse out/Default
In Eclipse, do File->Import->C/C++->C/C++ Project Settings, choose the XML location under packages/modules/Bluetooth/system/out/Default
Right click on the project. Go to Preferences->C/C++ Build->Builder Settings. Uncheck "Use default build command", but instead using "ninja -C out/Default"
Goto Behaviour tab, change clean command to "-t clean"