| commit | 62a1ad0001dadedd2e18bc1a8fb6e566e255332c | [log] [tgz] |
|---|---|---|
| author | Joonghong Park <joonghong.park@samsung.com> | Mon Apr 22 08:26:58 2019 +0900 |
| committer | Ted Wang <tedwang@google.com> | Wed Sep 04 21:41:41 2019 +0800 |
| tree | 74ed67cd2b83dcf36624e1999b6ca04f78f32091 | |
| parent | 9e83b7acaa85994b4f58fc37d0629d6ce41a26f9 [diff] |
AVRCP: Keep the device in the map on disconnect Fixes a stack crash when disconnecting AVRCP If an AVRCP connection, established by AVRC_OPEN_IND_EVT, is disconnected by calling DisconnectDevice() in Connection Handler, there is a corner case that does not clear Connection Control Block (CCB) entirely of a opened handle. So when there is re-connection trials, partially cleared CCBs causes a critical stack crash. When calling DisconnectDevice() in Connection Handler, there are issues. -Keeping removed CCB info partially, such as member variable "allocated", even though receiving AVRC_CLOSE_IND_EVT followed by clearing Link Control Block (LCB). -Keeping remote device address in feature_map_ This commit fixes the issue of above scenario, by keeping handle in device_map_ and removing to send disconnected notification when calling DisconnectDevice(). So when receiving AVRC_CLOSE_IND_EVT, normal procedure is conducted. Note that AVRC_CLOSE_IND_EVT is occurred by both AVCT_DISCONNECT_IND_EVT and AVCT_DISCONNECT_CFM_EVT. And when calling avrc_->Close() in DisconnectDevice(), it just requests to unbind LCB instead of dealloc CCB. And when receiving AVRC_CLOSE_IND_EVT avrc_->Close() dealloc CCB. Bug:139642151 Test: Test on phone with some products which has A/V Remote Control such as Britz(BE-ME350) and airpod Change-Id: Ic8bc3459afd4518447d6d52b1f8afb7b3e09a8b5 Signed-off-by: Joonghong Park <joonghong.park@samsung.com>
Just build AOSP - Fluoride is there by default.
Instructions for Ubuntu, tested on 14.04 with Clang 3.5.0 and 16.10 with Clang 3.8.0
mkdir ~/fluoride cd ~/fluoride git clone https://android.googlesource.com/platform/packages/modules/Bluetooth/system
Install dependencies (require sudo access):
cd ~/fluoride/bt build/install_deps.sh
Then fetch third party dependencies:
cd ~/fluoride/bt mkdir third_party cd third_party git clone https://github.com/google/googletest.git git clone https://android.googlesource.com/platform/external/aac git clone https://android.googlesource.com/platform/external/libchrome git clone https://android.googlesource.com/platform/external/libldac git clone https://android.googlesource.com/platform/external/modp_b64 git clone https://android.googlesource.com/platform/external/tinyxml2
And third party dependencies of third party dependencies:
cd fluoride/bt/third_party/libchrome/base/third_party mkdir valgrind cd valgrind curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/valgrind.h?format=TEXT | base64 -d > valgrind.h curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/memcheck.h?format=TEXT | base64 -d > memcheck.h
NOTE: If packages/modules/Bluetooth/system is checked out under AOSP, then create symbolic links instead of downloading sources
cd packages/modules/Bluetooth/system mkdir third_party cd third_party ln -s ../../../external/aac aac ln -s ../../../external/libchrome libchrome ln -s ../../../external/libldac libldac ln -s ../../../external/modp_b64 modp_b64 ln -s ../../../external/tinyxml2 tinyxml2 ln -s ../../../external/googletest googletest
cd ~/fluoride/bt gn gen out/Default
cd ~/fluoride/bt ninja -C out/Default all
This will build all targets (the shared library, executables, tests, etc) and put them in out/Default. To build an individual target, replace "all" with the target of your choice, e.g. ninja -C out/Default net_test_osi.
cd ~/fluoride/bt/out/Default LD_LIBRARY_PATH=./ ./bluetoothtbd -create-ipc-socket=fluoride
Follows the Chromium project Eclipse Setup Instructions until "Optional: Building inside Eclipse" section (don't do that section, we will set it up differently)
Generate Eclipse settings:
cd packages/modules/Bluetooth/system gn gen --ide=eclipse out/Default
In Eclipse, do File->Import->C/C++->C/C++ Project Settings, choose the XML location under packages/modules/Bluetooth/system/out/Default
Right click on the project. Go to Preferences->C/C++ Build->Builder Settings. Uncheck "Use default build command", but instead using "ninja -C out/Default"
Goto Behaviour tab, change clean command to "-t clean"