| commit | f30028da128347ede545a6b1f4645ca7f769efb1 | [log] [tgz] |
|---|---|---|
| author | Cheney Ni <cheneyni@google.com> | Sun Apr 12 05:19:31 2020 +0800 |
| committer | Cheney Ni <cheneyni@google.com> | Fri Apr 17 23:34:07 2020 +0800 |
| tree | f111015b95af8ae6b4fa12f679c40d77d18ac822 | |
| parent | 9217e00d7402d372802924100f78be00c47b3df1 [diff] |
A2DP: Fix integer sanitizer in SBC encoder There were three potential integer overflow within SBC software encoder: * embdrv/sbc/encoder/srce/sbc_packing.c:144:38: runtime error: unsigned integer overflow: 4294967231 + 8192 cannot be represented in type 'unsigned int' * embdrv/sbc/encoder/srce/sbc_packing.c:147:9: runtime error: signed integer overflow: 37932 * 65535 cannot be represented in type 'int' * embdrv/sbc/encoder/srce/sbc_packing.c:147:9: runtime error: signed integer overflow: 178177545 + 2146959360 cannot be represented in type 'int' They were caught by the integer sanitizer, and 1. (*ps32SbPtr >> 2) is either greater than 0xFF00,0000 or less than 0x007F,FFFF, so just cast to a signed integer explicitly. 2. Positive integer between 0x8000,0000 ~ 0xFFFF,FFFF can't be represented in type 'int', but is still feasible in 32-bits. 3. s32OutLow is the lower byte of a 64 bits integer, but can't have the carry values which is only for the higher byte. This change gives the compiler a signed 64-bits variable, and trusts it to do better optimization at multiplication. Bug: 153402404 Test: make sure there are no integer sanitization errors. Change-Id: I5046a42f9927c1aa7c25da2828c4f921ba7a5021
Just build AOSP - Fluoride is there by default.
Instructions for Ubuntu, tested on 14.04 with Clang 3.5.0 and 16.10 with Clang 3.8.0
mkdir ~/fluoride cd ~/fluoride git clone https://android.googlesource.com/platform/packages/modules/Bluetooth/system
Install dependencies (require sudo access):
cd ~/fluoride/bt build/install_deps.sh
Then fetch third party dependencies:
cd ~/fluoride/bt mkdir third_party cd third_party git clone https://github.com/google/googletest.git git clone https://android.googlesource.com/platform/external/aac git clone https://android.googlesource.com/platform/external/libchrome git clone https://android.googlesource.com/platform/external/libldac git clone https://android.googlesource.com/platform/external/modp_b64 git clone https://android.googlesource.com/platform/external/tinyxml2
And third party dependencies of third party dependencies:
cd fluoride/bt/third_party/libchrome/base/third_party mkdir valgrind cd valgrind curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/valgrind.h?format=TEXT | base64 -d > valgrind.h curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/memcheck.h?format=TEXT | base64 -d > memcheck.h
NOTE: If packages/modules/Bluetooth/system is checked out under AOSP, then create symbolic links instead of downloading sources
cd packages/modules/Bluetooth/system mkdir third_party cd third_party ln -s ../../../external/aac aac ln -s ../../../external/libchrome libchrome ln -s ../../../external/libldac libldac ln -s ../../../external/modp_b64 modp_b64 ln -s ../../../external/tinyxml2 tinyxml2 ln -s ../../../external/googletest googletest
cd ~/fluoride/bt gn gen out/Default
cd ~/fluoride/bt ninja -C out/Default all
This will build all targets (the shared library, executables, tests, etc) and put them in out/Default. To build an individual target, replace "all" with the target of your choice, e.g. ninja -C out/Default net_test_osi.
cd ~/fluoride/bt/out/Default LD_LIBRARY_PATH=./ ./bluetoothtbd -create-ipc-socket=fluoride
Follows the Chromium project Eclipse Setup Instructions until "Optional: Building inside Eclipse" section (don't do that section, we will set it up differently)
Generate Eclipse settings:
cd packages/modules/Bluetooth/system gn gen --ide=eclipse out/Default
In Eclipse, do File->Import->C/C++->C/C++ Project Settings, choose the XML location under packages/modules/Bluetooth/system/out/Default
Right click on the project. Go to Preferences->C/C++ Build->Builder Settings. Uncheck "Use default build command", but instead using "ninja -C out/Default"
Goto Behaviour tab, change clean command to "-t clean"