commit 2ac08bb9f107eebf75c018a09217172663a67302
author Chiachang Wang <chiachangwang@google.com> Wed Apr 14 16:54:52 2021 +0000
committer Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> Wed Apr 14 16:54:52 2021 +0000
tree 34968195efc6f71973d6bf43e4ef3897bf6e53bf
parent 752d035896cc489aebd54012ba7e523c81595371
parent 8cc30c0ad122dbd2e72d640c7d530bd4a3032338

Remove hidden connectivity methods usage in ethernet test am: 8cc30c0ad1

Original change: https://android-review.googlesource.com/c/platform/frameworks/opt/net/ethernet/+/1675425

Change-Id: I12c4e276c23bf73cd5642f088c029fc1d57ff6e3

tests/ethernet/java/com/android/server/ethernet/EthernetTrackerTest.java

diff --git a/tests/ethernet/java/com/android/server/ethernet/EthernetTrackerTest.java b/tests/ethernet/java/com/android/server/ethernet/EthernetTrackerTest.java
index 43571bb..22b1b69 100644
--- a/tests/ethernet/java/com/android/server/ethernet/EthernetTrackerTest.java
+++ b/tests/ethernet/java/com/android/server/ethernet/EthernetTrackerTest.java
@@ -19,6 +19,7 @@
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.fail;
 
+import android.net.InetAddresses;
 import android.net.IpConfiguration;
 import android.net.IpConfiguration.IpAssignment;
 import android.net.IpConfiguration.ProxySettings;
@@ -33,6 +34,7 @@
 import org.junit.runner.RunWith;
 
 import java.net.InetAddress;
+import java.util.ArrayList;
 
 @SmallTest
 @RunWith(AndroidJUnit4.class)
@@ -46,28 +48,26 @@
         assertStaticConfiguration(new StaticIpConfiguration(), "");
 
         // Setting only the IP address properly cascades and assumes defaults
-        assertStaticConfiguration(
-                new StaticIpConfigBuilder().setIp("192.0.2.10/24").build(),
-                "ip=192.0.2.10/24");
+        assertStaticConfiguration(new StaticIpConfiguration.Builder()
+                .setIpAddress(new LinkAddress("192.0.2.10/24")).build(), "ip=192.0.2.10/24");
 
+        final ArrayList<InetAddress> dnsAddresses = new ArrayList<>();
+        dnsAddresses.add(InetAddresses.parseNumericAddress("4.4.4.4"));
+        dnsAddresses.add(InetAddresses.parseNumericAddress("8.8.8.8"));
         // Setting other fields properly cascades them
-        assertStaticConfiguration(
-                new StaticIpConfigBuilder()
-                        .setIp("192.0.2.10/24")
-                        .setDns(new String[] {"4.4.4.4", "8.8.8.8"})
-                        .setGateway("192.0.2.1")
-                        .setDomains("android")
-                        .build(),
+        assertStaticConfiguration(new StaticIpConfiguration.Builder()
+                .setIpAddress(new LinkAddress("192.0.2.10/24"))
+                .setDnsServers(dnsAddresses)
+                .setGateway(InetAddresses.parseNumericAddress("192.0.2.1"))
+                .setDomains("android").build(),
                 "ip=192.0.2.10/24 dns=4.4.4.4,8.8.8.8 gateway=192.0.2.1 domains=android");
 
         // Verify order doesn't matter
-        assertStaticConfiguration(
-                new StaticIpConfigBuilder()
-                        .setIp("192.0.2.10/24")
-                        .setDns(new String[] {"4.4.4.4", "8.8.8.8"})
-                        .setGateway("192.0.2.1")
-                        .setDomains("android")
-                        .build(),
+        assertStaticConfiguration(new StaticIpConfiguration.Builder()
+                .setIpAddress(new LinkAddress("192.0.2.10/24"))
+                .setDnsServers(dnsAddresses)
+                .setGateway(InetAddresses.parseNumericAddress("192.0.2.1"))
+                .setDomains("android").build(),
                 "domains=android ip=192.0.2.10/24 gateway=192.0.2.1 dns=4.4.4.4,8.8.8.8 ");
     }
 
@@ -96,43 +96,15 @@
 
     private void assertStaticConfiguration(StaticIpConfiguration expectedStaticIpConfig,
                 String configAsString) {
-        IpConfiguration expectedIpConfiguration = new IpConfiguration(IpAssignment.STATIC,
-                ProxySettings.NONE, expectedStaticIpConfig, null);
+        final IpConfiguration expectedIpConfiguration = new IpConfiguration();
+        expectedIpConfiguration.setIpAssignment(IpAssignment.STATIC);
+        expectedIpConfiguration.setProxySettings(ProxySettings.NONE);
+        expectedIpConfiguration.setStaticIpConfiguration(expectedStaticIpConfig);
 
         assertEquals(expectedIpConfiguration,
                 EthernetTracker.parseStaticIpConfiguration(configAsString));
     }
 
-    private static class StaticIpConfigBuilder {
-        private final StaticIpConfiguration config = new StaticIpConfiguration();
-
-        StaticIpConfigBuilder setIp(String address) {
-            config.ipAddress = new LinkAddress(address);
-            return this;
-        }
-
-        StaticIpConfigBuilder setDns(String[] dnsArray) {
-            for (String dns : dnsArray) {
-                config.dnsServers.add(InetAddress.parseNumericAddress(dns));
-            }
-            return this;
-        }
-
-        StaticIpConfigBuilder setGateway(String gateway) {
-            config.gateway = InetAddress.parseNumericAddress(gateway);
-            return this;
-        }
-
-        StaticIpConfigBuilder setDomains(String domains) {
-            config.domains = domains;
-            return this;
-        }
-
-        StaticIpConfiguration build() {
-            return new StaticIpConfiguration(config);
-        }
-    }
-
     private NetworkCapabilities.Builder makeEthernetCapabilitiesBuilder(boolean clearAll) {
         final NetworkCapabilities.Builder builder =
                 clearAll ? new NetworkCapabilities.Builder().clearAll()