tree 21ee994e3ac492339f49fe44c6c72872539d4281
parent 873cb0ef24be9bd5140c48ade6a12b0491060d38
author Chiachang Wang <chiachangwang@google.com> 1618801164 +0800
committer Chiachang Wang <chiachangwang@google.com> 1618801755 +0800

Update the permission check for dump

ServicePermissionsTest#testDumpProtected expects to see nothing
from dump() if the caller does not have the required permission.

After the refactor the ConnectivityService#dump(). It does not
leak real information for those callers without permission but
show the title of dumpsys, i.e. it shows "DUMP OF SERVICE HIGH
connectivity". This breaks the test since the test expects to
see nothing.

Move the permission check to the front of dump call stack since
there is no way to call other private dump related methods.

Bug: 185425662
Test: atest android.security.cts.ServicePermissionsTest
Test: adb shell dumpsys connectivity
Change-Id: I173c968a4f1c4d6f618ed87725a6ccda8d309988