Gitiles
Code Review Sign In
review.blissroms.org / platform_packages_modules_DnsResolver / 0d08fbea8dce204e45edcf5e5fa1edd1484d1e3e
commit0d08fbea8dce204e45edcf5e5fa1edd1484d1e3e[log] [tgz]
authorKen Chen <cken@google.com>Tue Oct 22 21:38:20 2019 +0800
committerKen Chen <cken@google.com>Tue Oct 29 07:31:58 2019 +0800
tree8196640f2ad9ac4a4ac90fc1ebb98c4140c226c0
parenteffead990e4cbc5d2f257214aaf19650494566da [diff]
Support variety of IPv6 addresses on RDNS-on-cache

IPv6 address has multiple representation formats. The following
addresses are the same:

  "2001:db8::102:304"
  "2001:0db8:0000:0000:0000:0000:0102:0304"
  "2001:db8::1.2.3.4"

In original design, the RDNS-on-cache can only match IPv6 address with
format "2001:db8::102:304", but not with the others. It is because all
different representations are converted to a single binary form while
they are stored in cache. And of course, it will be a single format if
the cached IP address is converted back to text form while doing text
comparison. In this commit, the RDNS-on-cache converts query address to
binary form and binary compares with cached entry, rather than text
comparison. Also, add two test cases.

Bug: 131051938
Test: atest resolv_cache_unit_test.cpp#GetHostByAddrFromCache_InvalidArgs
      atest resolv_cache_unit_test.cpp#GetHostByAddrFromCache
Change-Id: I064f4bafca91ad7dbbd9b37ce3c2d05f8d6b954d
5 files changed
tree: 8196640f2ad9ac4a4ac90fc1ebb98c4140c226c0
  1. aidl/
  2. apex/
  3. binder/
  4. include/
  5. tests/
  6. .clang-format ⇨ ../../../build/soong/scripts/system-clang-format
  7. .editorconfig
  8. Android.bp
  9. Dns64Configuration.cpp
  10. Dns64Configuration.h
  11. DnsProxyListener.cpp
  12. DnsProxyListener.h
  13. DnsResolver.cpp
  14. DnsResolver.h
  15. dnsresolver_binder_test.cpp
  16. DnsResolverService.cpp
  17. DnsResolverService.h
  18. DnsStats.cpp
  19. DnsStats.h
  20. DnsStatsTest.cpp
  21. DnsTlsDispatcher.cpp
  22. DnsTlsDispatcher.h
  23. DnsTlsQueryMap.cpp
  24. DnsTlsQueryMap.h
  25. DnsTlsServer.cpp
  26. DnsTlsServer.h
  27. DnsTlsSessionCache.cpp
  28. DnsTlsSessionCache.h
  29. DnsTlsSocket.cpp
  30. DnsTlsSocket.h
  31. DnsTlsSocketFactory.h
  32. DnsTlsTransport.cpp
  33. DnsTlsTransport.h
  34. getaddrinfo.cpp
  35. getaddrinfo.h
  36. gethnamaddr.cpp
  37. gethnamaddr.h
  38. hostent.h
  39. IDnsTlsSocket.h
  40. IDnsTlsSocketFactory.h
  41. IDnsTlsSocketObserver.h
  42. libnetd_resolv.map.txt
  43. LockedQueue.h
  44. NOTICE
  45. OWNERS
  46. PREUPLOAD.cfg
  47. PrivateDnsConfiguration.cpp
  48. PrivateDnsConfiguration.h
  49. README-DoT.md
  50. README.md
  51. res_cache.cpp
  52. res_comp.cpp
  53. res_debug.cpp
  54. res_debug.h
  55. res_init.cpp
  56. res_init.h
  57. res_mkquery.cpp
  58. res_query.cpp
  59. res_send.cpp
  60. res_send.h
  61. res_stats.cpp
  62. resolv_cache.h
  63. resolv_cache_unit_test.cpp
  64. resolv_integration_test.cpp
  65. resolv_private.h
  66. resolv_tls_unit_test.cpp
  67. resolv_unit_test.cpp
  68. ResolverController.cpp
  69. ResolverController.h
  70. ResolverEventReporter.cpp
  71. ResolverEventReporter.h
  72. ResolverStats.h
  73. sethostent.cpp
  74. stats.proto
  75. TEST_MAPPING
README.md

Logging

This code uses LOG(X) for logging. Log levels are VERBOSE,DEBUG,INFO,WARNING and ERROR. The default setting is WARNING and logs relate to WARNING and ERROR will be shown. If you want to enable the DEBUG level logs, using following command. adb shell service call dnsresolver 10 i32 1 VERBOSE 0 DEBUG 1 INFO 2 WARNING 3 ERROR 4 Verbose resolver logs could contain PII -- do NOT enable in production builds.