Gitiles
Code Review Sign In
review.blissroms.org / platform_packages_modules_DnsResolver / e92297241f47eabb97b99e8be194172a17a9410a
commite92297241f47eabb97b99e8be194172a17a9410a[log] [tgz]
authorMaciej Żenczykowski <maze@google.com>Wed Feb 24 17:40:05 2021 -0800
committerMaciej Żenczykowski <maze@google.com>Wed Feb 24 18:08:54 2021 -0800
tree53c094e22aefc5f7a48ae2138864e1383ce6a639
parentfd4ac10ea84d53689ce02dcf154b68163a75c307 [diff]
ResolverController - fix NAT64 prefix logging a 'char' instead of an int.

Currently we have:
  D ResolverController: Sending Nat64Prefix added event on netId 100 with address {64:ff9b::(`)}

This is because:
  struct Nat64PrefixInfo {
    unsigned netId;
    bool added;
    std::string prefixString;
    uint8_t prefixLength;
  };

and thus the uint8_t is simply treated as a char(acter).

Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I2a5e1ed7a1d3072c7338b1a1288540682b5514d6
1 file changed
tree: 53c094e22aefc5f7a48ae2138864e1383ce6a639
  1. aidl_api/
  2. apex/
  3. binder/
  4. include/
  5. tests/
  6. .clang-format ⇨ ../../../build/soong/scripts/system-clang-format
  7. rustfmt.toml ⇨ ../../../build/soong/scripts/rustfmt.toml
  8. .editorconfig
  9. Android.bp
  10. Dns64Configuration.cpp
  11. Dns64Configuration.h
  12. DnsProxyListener.cpp
  13. DnsProxyListener.h
  14. DnsQueryLog.cpp
  15. DnsQueryLog.h
  16. DnsQueryLogTest.cpp
  17. DnsResolver.cpp
  18. DnsResolver.h
  19. DnsResolverService.cpp
  20. DnsResolverService.h
  21. DnsStats.cpp
  22. DnsStats.h
  23. DnsStatsTest.cpp
  24. DnsTlsDispatcher.cpp
  25. DnsTlsDispatcher.h
  26. DnsTlsQueryMap.cpp
  27. DnsTlsQueryMap.h
  28. DnsTlsServer.cpp
  29. DnsTlsServer.h
  30. DnsTlsSessionCache.cpp
  31. DnsTlsSessionCache.h
  32. DnsTlsSocket.cpp
  33. DnsTlsSocket.h
  34. DnsTlsSocketFactory.h
  35. DnsTlsTransport.cpp
  36. DnsTlsTransport.h
  37. Experiments.cpp
  38. Experiments.h
  39. ExperimentsTest.cpp
  40. getaddrinfo.cpp
  41. getaddrinfo.h
  42. gethnamaddr.cpp
  43. gethnamaddr.h
  44. hostent.h
  45. IDnsTlsSocket.h
  46. IDnsTlsSocketFactory.h
  47. IDnsTlsSocketObserver.h
  48. libnetd_resolv.map.txt
  49. LockedQueue.h
  50. NOTICE
  51. OperationLimiter.h
  52. OperationLimiterTest.cpp
  53. OWNERS
  54. params.h
  55. PREUPLOAD.cfg
  56. PrivateDnsCommon.h
  57. PrivateDnsConfiguration.cpp
  58. PrivateDnsConfiguration.h
  59. PrivateDnsConfigurationTest.cpp
  60. PrivateDnsValidationObserver.h
  61. README-DoT.md
  62. README.md
  63. res_cache.cpp
  64. res_comp.cpp
  65. res_comp.h
  66. res_debug.cpp
  67. res_debug.h
  68. res_mkquery.cpp
  69. res_query.cpp
  70. res_send.cpp
  71. res_send.h
  72. res_stats.cpp
  73. resolv_cache.h
  74. resolv_cache_unit_test.cpp
  75. resolv_callback_unit_test.cpp
  76. resolv_private.h
  77. resolv_test_config_template.xml
  78. resolv_tls_unit_test.cpp
  79. resolv_unit_test.cpp
  80. ResolverController.cpp
  81. ResolverController.h
  82. ResolverEventReporter.cpp
  83. ResolverEventReporter.h
  84. ResolverStats.h
  85. sethostent.cpp
  86. stats.h
  87. stats.proto
  88. TEST_MAPPING
  89. util.cpp
  90. util.h
README.md

Logging

This code uses LOG(X) for logging. Log levels are VERBOSE,DEBUG,INFO,WARNING and ERROR. The default setting is WARNING and logs relate to WARNING and ERROR will be shown. If you want to enable the DEBUG level logs, using following command. adb shell service call dnsresolver 10 i32 1 VERBOSE 0 DEBUG 1 INFO 2 WARNING 3 ERROR 4 Verbose resolver logs could contain PII -- do NOT enable in production builds.