Gitiles
Code Review Sign In
review.blissroms.org / platform_packages_modules_DnsResolver / 229fedcb96f5ee24eb384823ae883502a718edef
commit229fedcb96f5ee24eb384823ae883502a718edef[log] [tgz]
authorMike Yu <yumike@google.com>Mon Dec 20 18:57:08 2021 +0800
committerMike Yu <yumike@google.com>Mon Dec 20 19:40:35 2021 +0800
tree451f6f2fe4244c64386a45d8a105ddf72104ba62
parent03a274f82b3bf81f8dd87211af18f69c67d9f915 [diff]
Make DohFrontend::clearQueries() synchronous

Sending a DNS query right after DohFrontend::clearQueries() is
commonly seen in PrivateDnsDohTest. However, it has a race issue
because frontend_stats_clear_queries() is asynchronous. Some
PrivateDnsDohTest tests are flaky due to that.

This change ensures that DohFrontend::clearQueries() returns after
the query count is reset.

Fix: 211362650
Test: Ran PrivateDnsDohTest.PreferIpv6 1000 times
Change-Id: I537c44b2015075130100e19279070c3e1ff698d3
2 files changed
tree: 451f6f2fe4244c64386a45d8a105ddf72104ba62
  1. aidl_api/
  2. apex/
  3. binder/
  4. doh/
  5. include/
  6. tests/
  7. .clang-format ⇨ ../../../build/soong/scripts/system-clang-format
  8. rustfmt.toml ⇨ ../../../build/soong/scripts/rustfmt.toml
  9. .editorconfig
  10. Android.bp
  11. cbindgen.toml
  12. Dns64Configuration.cpp
  13. Dns64Configuration.h
  14. DnsProxyListener.cpp
  15. DnsProxyListener.h
  16. DnsQueryLog.cpp
  17. DnsQueryLog.h
  18. DnsQueryLogTest.cpp
  19. DnsResolver.cpp
  20. DnsResolver.h
  21. DnsResolverService.cpp
  22. DnsResolverService.h
  23. DnsStats.cpp
  24. DnsStats.h
  25. DnsStatsTest.cpp
  26. DnsTlsDispatcher.cpp
  27. DnsTlsDispatcher.h
  28. DnsTlsQueryMap.cpp
  29. DnsTlsQueryMap.h
  30. DnsTlsServer.cpp
  31. DnsTlsServer.h
  32. DnsTlsSessionCache.cpp
  33. DnsTlsSessionCache.h
  34. DnsTlsSocket.cpp
  35. DnsTlsSocket.h
  36. DnsTlsSocketFactory.h
  37. DnsTlsTransport.cpp
  38. DnsTlsTransport.h
  39. doh.h
  40. Experiments.cpp
  41. Experiments.h
  42. ExperimentsTest.cpp
  43. getaddrinfo.cpp
  44. getaddrinfo.h
  45. gethnamaddr.cpp
  46. gethnamaddr.h
  47. hostent.h
  48. IDnsTlsSocket.h
  49. IDnsTlsSocketFactory.h
  50. IDnsTlsSocketObserver.h
  51. IPrivateDnsServer.h
  52. libnetd_resolv.map.txt
  53. LockedQueue.h
  54. NOTICE
  55. OperationLimiter.h
  56. OperationLimiterTest.cpp
  57. OWNERS
  58. params.h
  59. PREUPLOAD.cfg
  60. PrivateDnsCommon.h
  61. PrivateDnsConfiguration.cpp
  62. PrivateDnsConfiguration.h
  63. PrivateDnsConfigurationTest.cpp
  64. PrivateDnsValidationObserver.h
  65. README-DoT.md
  66. README.md
  67. res_cache.cpp
  68. res_comp.cpp
  69. res_comp.h
  70. res_debug.cpp
  71. res_debug.h
  72. res_mkquery.cpp
  73. res_query.cpp
  74. res_send.cpp
  75. res_send.h
  76. res_stats.cpp
  77. resolv_cache.h
  78. resolv_private.h
  79. resolv_rust_test_config_template.xml
  80. resolv_test_config_template.xml
  81. ResolverController.cpp
  82. ResolverController.h
  83. ResolverEventReporter.cpp
  84. ResolverEventReporter.h
  85. ResolverStats.h
  86. sethostent.cpp
  87. stats.h
  88. stats.proto
  89. TEST_MAPPING
  90. util.cpp
  91. util.h
README.md

Logging

This code uses LOG(X) for logging. Log levels are VERBOSE,DEBUG,INFO,WARNING and ERROR. The default setting is WARNING and logs relate to WARNING and ERROR will be shown. If you want to enable the DEBUG level logs, using following command. adb shell service call dnsresolver 10 i32 1 VERBOSE 0 DEBUG 1 INFO 2 WARNING 3 ERROR 4 Verbose resolver logs could contain PII -- do NOT enable in production builds.