Gitiles
Code Review Sign In
review.blissroms.org / platform_packages_modules_DnsResolver / 23b1f138150a1abf2d7180edd6bd6a42f52989fe
commit23b1f138150a1abf2d7180edd6bd6a42f52989fe[log] [tgz]
authorStephen Hines <srhines@google.com>Fri Aug 21 12:38:12 2020 -0700
committerStephen Hines <srhines@google.com>Tue Aug 25 15:05:27 2020 -0700
tree4c7585debe6a63421e8b0c25b90526e2f81172f9
parent957333d2a99861bc9e01a96605a6de1f4ea4cabd [diff]
Fix tidy warnings for r399163 Clang update.

Fix tidy warnings signed char -> int conversions.

/disk/android_trees/aosp-master-plus-llvm/packages/modules/DnsResolver/res_comp.cpp:144:28: error: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [cert-str34-c,-warnings-as-errors]
    int pch = PERIOD, ch = *dn++;
                           ^
/disk/android_trees/aosp-master-plus-llvm/packages/modules/DnsResolver/res_comp.cpp:147:19: error: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [cert-str34-c,-warnings-as-errors]
        int nch = *dn++;
                  ^
/disk/android_trees/aosp-master-plus-llvm/packages/modules/DnsResolver/res_comp.cpp:168:18: error: 'signed char' to 'int' conversion; consider casting to 'unsigned char' first. [cert-str34-c,-warnings-as-errors]
    while ((ch = *dn++) != '\0')
                 ^

Fix tidy warnings for unused result by casting to void.

/disk/android_trees/aosp-master-plus-llvm/packages/modules/DnsResolver/tests/dns_responder/dns_tls_frontend.cpp:155:5: error: the value returned by this function should be used [bugprone-unused-return-value,-warnings-as-errors]
    connect(backend_socket_.get(), backend_ai_res->ai_addr, backend_ai_res->ai_addrlen);
    ^

Bug: http://b/155835175
Test: m

Change-Id: Iada74f5c50a563012bfd26cee9088a3a72371f56
2 files changed
tree: 4c7585debe6a63421e8b0c25b90526e2f81172f9
  1. aidl_api/
  2. apex/
  3. binder/
  4. include/
  5. tests/
  6. .clang-format ⇨ ../../../build/soong/scripts/system-clang-format
  7. .editorconfig
  8. Android.bp
  9. Dns64Configuration.cpp
  10. Dns64Configuration.h
  11. DnsProxyListener.cpp
  12. DnsProxyListener.h
  13. DnsQueryLog.cpp
  14. DnsQueryLog.h
  15. DnsQueryLogTest.cpp
  16. DnsResolver.cpp
  17. DnsResolver.h
  18. DnsResolverService.cpp
  19. DnsResolverService.h
  20. DnsStats.cpp
  21. DnsStats.h
  22. DnsStatsTest.cpp
  23. DnsTlsDispatcher.cpp
  24. DnsTlsDispatcher.h
  25. DnsTlsQueryMap.cpp
  26. DnsTlsQueryMap.h
  27. DnsTlsServer.cpp
  28. DnsTlsServer.h
  29. DnsTlsSessionCache.cpp
  30. DnsTlsSessionCache.h
  31. DnsTlsSocket.cpp
  32. DnsTlsSocket.h
  33. DnsTlsSocketFactory.h
  34. DnsTlsTransport.cpp
  35. DnsTlsTransport.h
  36. Experiments.cpp
  37. Experiments.h
  38. ExperimentsTest.cpp
  39. getaddrinfo.cpp
  40. getaddrinfo.h
  41. gethnamaddr.cpp
  42. gethnamaddr.h
  43. hostent.h
  44. IDnsTlsSocket.h
  45. IDnsTlsSocketFactory.h
  46. IDnsTlsSocketObserver.h
  47. libnetd_resolv.map.txt
  48. LockedQueue.h
  49. NOTICE
  50. OWNERS
  51. params.h
  52. PREUPLOAD.cfg
  53. PrivateDnsConfiguration.cpp
  54. PrivateDnsConfiguration.h
  55. README-DoT.md
  56. README.md
  57. res_cache.cpp
  58. res_comp.cpp
  59. res_comp.h
  60. res_debug.cpp
  61. res_debug.h
  62. res_init.cpp
  63. res_init.h
  64. res_mkquery.cpp
  65. res_query.cpp
  66. res_send.cpp
  67. res_send.h
  68. res_stats.cpp
  69. resolv_cache.h
  70. resolv_cache_unit_test.cpp
  71. resolv_callback_unit_test.cpp
  72. resolv_private.h
  73. resolv_test_config_template.xml
  74. resolv_tls_unit_test.cpp
  75. resolv_unit_test.cpp
  76. ResolverController.cpp
  77. ResolverController.h
  78. ResolverEventReporter.cpp
  79. ResolverEventReporter.h
  80. ResolverStats.h
  81. sethostent.cpp
  82. stats.h
  83. stats.proto
  84. TEST_MAPPING
  85. util.cpp
  86. util.h
README.md

Logging

This code uses LOG(X) for logging. Log levels are VERBOSE,DEBUG,INFO,WARNING and ERROR. The default setting is WARNING and logs relate to WARNING and ERROR will be shown. If you want to enable the DEBUG level logs, using following command. adb shell service call dnsresolver 10 i32 1 VERBOSE 0 DEBUG 1 INFO 2 WARNING 3 ERROR 4 Verbose resolver logs could contain PII -- do NOT enable in production builds.