Gitiles
Code Review Sign In
review.blissroms.org / platform_packages_modules_DnsResolver / f7717f5a4f5200b0c413bbecb6fbf69df9bccdfc
commitf7717f5a4f5200b0c413bbecb6fbf69df9bccdfc[log] [tgz]
authorMike Yu <yumike@google.com>Tue Nov 24 17:31:12 2020 +0800
committerMike Yu <yumike@google.com>Fri Nov 27 21:11:51 2020 +0800
tree4d15a32e5df71d14587a02a9b55fce3c05b7206d
parentfa985f71afc584b27b9768f04fb9b5fdfcb047be [diff]
Remove validation threads tracking in PrivateDnsConfiguration

The validation threads tracking is not necessary since DnsTlsServer
itself can provide sufficient information to PrivateDnsConfiguration
to decide if a validation should start.

This change comprises:

[1] Remove mPrivateDnsValidateThreads and related functions
[2] Extend DnsTlsServer to tell if it is a present server for a
    network.
[3] PrivateDnsConfiguration reserves every DnsTlsServer object until
    being set to OFF mode or the network is destroyed. Make use of
    [2] to determine which servers should be active for the network.
[4] DnsTlsServers with identical IP address but different private
    DNS provider hostname are treated as different servers, and
    thus they have their own validation thread.
[5] Add a new state, Validation::success_but_expired, which is used
    to determine if a server which had passed the validation should
    be revalidated again.
[6] To fit in with [4], some related tests are modified.

Bug: 79727473
Test: cd packages/modules/DnsResolver && atest
Change-Id: I78afce543ea05be39c36d268576824e9ec798b12
6 files changed
tree: 4d15a32e5df71d14587a02a9b55fce3c05b7206d
  1. aidl_api/
  2. apex/
  3. binder/
  4. include/
  5. tests/
  6. .clang-format ⇨ ../../../build/soong/scripts/system-clang-format
  7. .editorconfig
  8. Android.bp
  9. Dns64Configuration.cpp
  10. Dns64Configuration.h
  11. DnsProxyListener.cpp
  12. DnsProxyListener.h
  13. DnsQueryLog.cpp
  14. DnsQueryLog.h
  15. DnsQueryLogTest.cpp
  16. DnsResolver.cpp
  17. DnsResolver.h
  18. DnsResolverService.cpp
  19. DnsResolverService.h
  20. DnsStats.cpp
  21. DnsStats.h
  22. DnsStatsTest.cpp
  23. DnsTlsDispatcher.cpp
  24. DnsTlsDispatcher.h
  25. DnsTlsQueryMap.cpp
  26. DnsTlsQueryMap.h
  27. DnsTlsServer.cpp
  28. DnsTlsServer.h
  29. DnsTlsSessionCache.cpp
  30. DnsTlsSessionCache.h
  31. DnsTlsSocket.cpp
  32. DnsTlsSocket.h
  33. DnsTlsSocketFactory.h
  34. DnsTlsTransport.cpp
  35. DnsTlsTransport.h
  36. Experiments.cpp
  37. Experiments.h
  38. ExperimentsTest.cpp
  39. getaddrinfo.cpp
  40. getaddrinfo.h
  41. gethnamaddr.cpp
  42. gethnamaddr.h
  43. hostent.h
  44. IDnsTlsSocket.h
  45. IDnsTlsSocketFactory.h
  46. IDnsTlsSocketObserver.h
  47. libnetd_resolv.map.txt
  48. LockedQueue.h
  49. NOTICE
  50. OWNERS
  51. params.h
  52. PREUPLOAD.cfg
  53. PrivateDnsConfiguration.cpp
  54. PrivateDnsConfiguration.h
  55. PrivateDnsConfigurationTest.cpp
  56. README-DoT.md
  57. README.md
  58. res_cache.cpp
  59. res_comp.cpp
  60. res_comp.h
  61. res_debug.cpp
  62. res_debug.h
  63. res_init.cpp
  64. res_init.h
  65. res_mkquery.cpp
  66. res_query.cpp
  67. res_send.cpp
  68. res_send.h
  69. res_stats.cpp
  70. resolv_cache.h
  71. resolv_cache_unit_test.cpp
  72. resolv_callback_unit_test.cpp
  73. resolv_private.h
  74. resolv_test_config_template.xml
  75. resolv_tls_unit_test.cpp
  76. resolv_unit_test.cpp
  77. ResolverController.cpp
  78. ResolverController.h
  79. ResolverEventReporter.cpp
  80. ResolverEventReporter.h
  81. ResolverStats.h
  82. sethostent.cpp
  83. stats.h
  84. stats.proto
  85. TEST_MAPPING
  86. util.cpp
  87. util.h
README.md

Logging

This code uses LOG(X) for logging. Log levels are VERBOSE,DEBUG,INFO,WARNING and ERROR. The default setting is WARNING and logs relate to WARNING and ERROR will be shown. If you want to enable the DEBUG level logs, using following command. adb shell service call dnsresolver 10 i32 1 VERBOSE 0 DEBUG 1 INFO 2 WARNING 3 ERROR 4 Verbose resolver logs could contain PII -- do NOT enable in production builds.