Gitiles
Code Review Sign In
review.blissroms.org / platform_packages_modules_DnsResolver / 4658b253e6de347175008426c6ac04e5b3f0b37e
commit4658b253e6de347175008426c6ac04e5b3f0b37e[log] [tgz]
authorLorenzo Colitti <lorenzo@google.com>Thu Nov 14 23:45:05 2019 +0900
committerLorenzo Colitti <lorenzo@google.com>Fri Nov 15 01:30:11 2019 +0900
tree5d44ece1cf91d8e6141cd4d335da62b4ac814c3e
parentd77eef74c7356ffd285a24bc4d837cd8bcafac4c [diff]
Don't allow a non-empty CA certificate in production code.

The caCertificate field in ResolverParamsParcel is documented as
being for testing only. Because setting it could have security
implications, don't allow the system server to pass it in.

Bug: 144475682
Test: existing tests pass
Change-Id: Ie0b826127cc48f18945a9de5f3579e47706462ee
2 files changed
tree: 5d44ece1cf91d8e6141cd4d335da62b4ac814c3e
  1. aidl/
  2. apex/
  3. binder/
  4. include/
  5. tests/
  6. .clang-format ⇨ ../../../build/soong/scripts/system-clang-format
  7. .editorconfig
  8. Android.bp
  9. Dns64Configuration.cpp
  10. Dns64Configuration.h
  11. DnsProxyListener.cpp
  12. DnsProxyListener.h
  13. DnsResolver.cpp
  14. DnsResolver.h
  15. dnsresolver_binder_test.cpp
  16. DnsResolverService.cpp
  17. DnsResolverService.h
  18. DnsStats.cpp
  19. DnsStats.h
  20. DnsStatsTest.cpp
  21. DnsTlsDispatcher.cpp
  22. DnsTlsDispatcher.h
  23. DnsTlsQueryMap.cpp
  24. DnsTlsQueryMap.h
  25. DnsTlsServer.cpp
  26. DnsTlsServer.h
  27. DnsTlsSessionCache.cpp
  28. DnsTlsSessionCache.h
  29. DnsTlsSocket.cpp
  30. DnsTlsSocket.h
  31. DnsTlsSocketFactory.h
  32. DnsTlsTransport.cpp
  33. DnsTlsTransport.h
  34. getaddrinfo.cpp
  35. getaddrinfo.h
  36. gethnamaddr.cpp
  37. gethnamaddr.h
  38. hostent.h
  39. IDnsTlsSocket.h
  40. IDnsTlsSocketFactory.h
  41. IDnsTlsSocketObserver.h
  42. libnetd_resolv.map.txt
  43. LockedQueue.h
  44. NOTICE
  45. OWNERS
  46. PREUPLOAD.cfg
  47. PrivateDnsConfiguration.cpp
  48. PrivateDnsConfiguration.h
  49. README-DoT.md
  50. README.md
  51. res_cache.cpp
  52. res_comp.cpp
  53. res_debug.cpp
  54. res_debug.h
  55. res_init.cpp
  56. res_init.h
  57. res_mkquery.cpp
  58. res_query.cpp
  59. res_send.cpp
  60. res_send.h
  61. res_stats.cpp
  62. resolv_cache.h
  63. resolv_cache_unit_test.cpp
  64. resolv_integration_test.cpp
  65. resolv_private.h
  66. resolv_tls_unit_test.cpp
  67. resolv_unit_test.cpp
  68. ResolverController.cpp
  69. ResolverController.h
  70. ResolverEventReporter.cpp
  71. ResolverEventReporter.h
  72. ResolverStats.h
  73. sethostent.cpp
  74. stats.proto
  75. TEST_MAPPING
  76. util.cpp
  77. util.h
README.md

Logging

This code uses LOG(X) for logging. Log levels are VERBOSE,DEBUG,INFO,WARNING and ERROR. The default setting is WARNING and logs relate to WARNING and ERROR will be shown. If you want to enable the DEBUG level logs, using following command. adb shell service call dnsresolver 10 i32 1 VERBOSE 0 DEBUG 1 INFO 2 WARNING 3 ERROR 4 Verbose resolver logs could contain PII -- do NOT enable in production builds.