Gitiles
Code Review Sign In
review.blissroms.org / platform_packages_modules_DnsResolver / db04a2bd0a35d6e74101535adffb5c8dab223fa7
commitdb04a2bd0a35d6e74101535adffb5c8dab223fa7[log] [tgz]
authorMike Yu <yumike@google.com>Tue Apr 27 14:21:03 2021 +0800
committerMike Yu <yumike@google.com>Wed Apr 28 16:53:01 2021 +0800
treeb8b9686b16fa69241e419be0892ea770f5739904
parent82ae84b9490e898eb839d0b807de23da27437c5b [diff]
Retry binding sockets in DNSResponder if errno is EADDRNOTAVAIL

Tests fail in DNSResponder::startServer() when DNSResponder is binding
the socket while the address is still being set up. This change provides
a simple fix to address this problem because the tests are unaware of
onInterfaceAddressUpdated.

Below is a real failure log:

// device log
04-22 00:29:07.854  root   802   802 I netd    : interfaceAddAddress("testtun10002", "2001:db8:2::202", 128) <1.51ms>
04-22 00:29:07.855  root  6745  6745 E DNSResponder: failed to bind UDP 2001:db8:2::202:53: Cannot assign requested address

// dumpsys netd
04-22 00:29:07.857 onInterfaceAddressUpdated(2001:db8:2::202/128, testtun10002, 128, 0) (0.04ms)

Bug: 186181084
Bug: 175269391
Test: run ResolverMultinetworkTest.GetAddrInfo_AI_ADDRCONFIG 100 times
Change-Id: I8e8824c9056bd298e0e689adfbc720abaa45fcd4
1 file changed
tree: b8b9686b16fa69241e419be0892ea770f5739904
  1. aidl_api/
  2. apex/
  3. binder/
  4. include/
  5. tests/
  6. .clang-format ⇨ ../../../build/soong/scripts/system-clang-format
  7. rustfmt.toml ⇨ ../../../build/soong/scripts/rustfmt.toml
  8. .editorconfig
  9. Android.bp
  10. cbindgen.toml
  11. Dns64Configuration.cpp
  12. Dns64Configuration.h
  13. DnsProxyListener.cpp
  14. DnsProxyListener.h
  15. DnsQueryLog.cpp
  16. DnsQueryLog.h
  17. DnsQueryLogTest.cpp
  18. DnsResolver.cpp
  19. DnsResolver.h
  20. DnsResolverService.cpp
  21. DnsResolverService.h
  22. DnsStats.cpp
  23. DnsStats.h
  24. DnsStatsTest.cpp
  25. DnsTlsDispatcher.cpp
  26. DnsTlsDispatcher.h
  27. DnsTlsQueryMap.cpp
  28. DnsTlsQueryMap.h
  29. DnsTlsServer.cpp
  30. DnsTlsServer.h
  31. DnsTlsSessionCache.cpp
  32. DnsTlsSessionCache.h
  33. DnsTlsSocket.cpp
  34. DnsTlsSocket.h
  35. DnsTlsSocketFactory.h
  36. DnsTlsTransport.cpp
  37. DnsTlsTransport.h
  38. doh.h
  39. doh.rs
  40. doh_ffi_test.cpp
  41. Experiments.cpp
  42. Experiments.h
  43. ExperimentsTest.cpp
  44. getaddrinfo.cpp
  45. getaddrinfo.h
  46. gethnamaddr.cpp
  47. gethnamaddr.h
  48. hostent.h
  49. IDnsTlsSocket.h
  50. IDnsTlsSocketFactory.h
  51. IDnsTlsSocketObserver.h
  52. libnetd_resolv.map.txt
  53. LockedQueue.h
  54. NOTICE
  55. OperationLimiter.h
  56. OperationLimiterTest.cpp
  57. OWNERS
  58. params.h
  59. PREUPLOAD.cfg
  60. PrivateDnsCommon.h
  61. PrivateDnsConfiguration.cpp
  62. PrivateDnsConfiguration.h
  63. PrivateDnsConfigurationTest.cpp
  64. PrivateDnsValidationObserver.h
  65. README-DoT.md
  66. README.md
  67. res_cache.cpp
  68. res_comp.cpp
  69. res_comp.h
  70. res_debug.cpp
  71. res_debug.h
  72. res_mkquery.cpp
  73. res_query.cpp
  74. res_send.cpp
  75. res_send.h
  76. res_stats.cpp
  77. resolv_cache.h
  78. resolv_private.h
  79. resolv_rust_test_config_template.xml
  80. resolv_test_config_template.xml
  81. ResolverController.cpp
  82. ResolverController.h
  83. ResolverEventReporter.cpp
  84. ResolverEventReporter.h
  85. ResolverStats.h
  86. sethostent.cpp
  87. stats.h
  88. stats.proto
  89. TEST_MAPPING
  90. util.cpp
  91. util.h
README.md

Logging

This code uses LOG(X) for logging. Log levels are VERBOSE,DEBUG,INFO,WARNING and ERROR. The default setting is WARNING and logs relate to WARNING and ERROR will be shown. If you want to enable the DEBUG level logs, using following command. adb shell service call dnsresolver 10 i32 1 VERBOSE 0 DEBUG 1 INFO 2 WARNING 3 ERROR 4 Verbose resolver logs could contain PII -- do NOT enable in production builds.