Gitiles
Code Review Sign In
review.blissroms.org / platform_packages_modules_DnsResolver / 88f87556b68e429dff34d57fd84073d5bb9e0a0d
commit88f87556b68e429dff34d57fd84073d5bb9e0a0d[log] [tgz]
authorMaciej Żenczykowski <maze@google.com>Thu Apr 23 08:48:36 2020 -0700
committerMaciej Żenczykowski <maze@google.com>Thu Apr 23 13:40:18 2020 -0700
treecb0e80def78db21ecd0c9d07df4f8ad744573d4a
parentc37d081df15cacfe8d65ba9e98df4b2390119a54 [diff]
DnsResolver/res_send.cpp - fixes bugprone-argument-comment warning

Fixes:
  packages/modules/DnsResolver/res_send.cpp:868:38: error: argument name 'sigmask' in comment does not match parameter name '__mask' [bugprone-argument-comment,-warnings-as-errors]
      int n = ppoll(&fds, 1, &timeout, /*sigmask=*/NULL);
                                       ^~~~~~~~~~~~
                                       /*__mask=*/
  bionic/libc/include/poll.h:64:129: note: '__mask' declared here
  int ppoll(struct pollfd* _Nullable __fds, nfds_t __count, const struct timespec* _Nullable __timeout, const sigset_t* _Nullable __mask) __INTRODUCED_IN(21);
                                                                                                                                  ^
  packages/modules/DnsResolver/res_send.cpp:907:67: error: argument name 'sigmask' in comment does not match parameter name '__mask' [bugprone-argument-comment,-warnings-as-errors]
          const int n = ppoll(fdset.data(), fdset.size(), &timeout, /*sigmask=*/nullptr);
                                                                    ^~~~~~~~~~~~
                                                                    /*__mask=*/
  bionic/libc/include/poll.h:64:129: note: '__mask' declared here
  int ppoll(struct pollfd* _Nullable __fds, nfds_t __count, const struct timespec* _Nullable __timeout, const sigset_t* _Nullable __mask) __INTRODUCED_IN(21);

Test: builds
Bug: 153035880
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: Iff535accfc09968f070a93daff9e4a5aded2e4bc
1 file changed
tree: cb0e80def78db21ecd0c9d07df4f8ad744573d4a
  1. aidl_api/
  2. apex/
  3. binder/
  4. include/
  5. tests/
  6. .clang-format ⇨ ../../../build/soong/scripts/system-clang-format
  7. .editorconfig
  8. Android.bp
  9. Dns64Configuration.cpp
  10. Dns64Configuration.h
  11. DnsProxyListener.cpp
  12. DnsProxyListener.h
  13. DnsQueryLog.cpp
  14. DnsQueryLog.h
  15. DnsQueryLogTest.cpp
  16. DnsResolver.cpp
  17. DnsResolver.h
  18. DnsResolverService.cpp
  19. DnsResolverService.h
  20. DnsStats.cpp
  21. DnsStats.h
  22. DnsStatsTest.cpp
  23. DnsTlsDispatcher.cpp
  24. DnsTlsDispatcher.h
  25. DnsTlsQueryMap.cpp
  26. DnsTlsQueryMap.h
  27. DnsTlsServer.cpp
  28. DnsTlsServer.h
  29. DnsTlsSessionCache.cpp
  30. DnsTlsSessionCache.h
  31. DnsTlsSocket.cpp
  32. DnsTlsSocket.h
  33. DnsTlsSocketFactory.h
  34. DnsTlsTransport.cpp
  35. DnsTlsTransport.h
  36. getaddrinfo.cpp
  37. getaddrinfo.h
  38. gethnamaddr.cpp
  39. gethnamaddr.h
  40. hostent.h
  41. IDnsTlsSocket.h
  42. IDnsTlsSocketFactory.h
  43. IDnsTlsSocketObserver.h
  44. libnetd_resolv.map.txt
  45. LockedQueue.h
  46. NOTICE
  47. OWNERS
  48. params.h
  49. PREUPLOAD.cfg
  50. PrivateDnsConfiguration.cpp
  51. PrivateDnsConfiguration.h
  52. README-DoT.md
  53. README.md
  54. res_cache.cpp
  55. res_comp.cpp
  56. res_comp.h
  57. res_debug.cpp
  58. res_debug.h
  59. res_init.cpp
  60. res_init.h
  61. res_mkquery.cpp
  62. res_query.cpp
  63. res_send.cpp
  64. res_send.h
  65. res_stats.cpp
  66. resolv_cache.h
  67. resolv_cache_unit_test.cpp
  68. resolv_callback_unit_test.cpp
  69. resolv_private.h
  70. resolv_test_config_template.xml
  71. resolv_tls_unit_test.cpp
  72. resolv_unit_test.cpp
  73. ResolverController.cpp
  74. ResolverController.h
  75. ResolverEventReporter.cpp
  76. ResolverEventReporter.h
  77. ResolverStats.h
  78. sethostent.cpp
  79. stats.h
  80. stats.proto
  81. TEST_MAPPING
  82. util.cpp
  83. util.h
README.md

Logging

This code uses LOG(X) for logging. Log levels are VERBOSE,DEBUG,INFO,WARNING and ERROR. The default setting is WARNING and logs relate to WARNING and ERROR will be shown. If you want to enable the DEBUG level logs, using following command. adb shell service call dnsresolver 10 i32 1 VERBOSE 0 DEBUG 1 INFO 2 WARNING 3 ERROR 4 Verbose resolver logs could contain PII -- do NOT enable in production builds.