Gitiles
Code Review Sign In
review.blissroms.org / platform_packages_modules_DnsResolver / 8ac634057f2a42d98329b6650661535eb98d43eb
commit8ac634057f2a42d98329b6650661535eb98d43eb[log] [tgz]
authorMike Yu <yumike@google.com>Mon Dec 02 15:28:38 2019 +0800
committerMike Yu <yumike@google.com>Tue Dec 03 15:14:53 2019 +0800
tree931c3bc8c22a2f6998c0e83af76987aa3d23d8a6
parentde6bd96046cb533d1c7f46f316c9fac2e83634d3 [diff]
Avoid keeping sending queries to an invalid nameserver

When a nameserver is known to be not workable due to wrong setup,
e.g. invalid address or network unreachable, it should be considered
unusable, just like what the code does for a nameserver which always
times out.

This change is beneficial to:
  [1] Fix the bug which the code can never mark all of the
      nameservers as unusable in some edge cases.
  [2] Decrease the noise of internal_error in the metrics.

Bug: 144828038
Test: cd packages/modules/DnsResolver && atest
Change-Id: Id84c49690a7ae1dbd209f9f7751120052efd6c13
3 files changed
tree: 931c3bc8c22a2f6998c0e83af76987aa3d23d8a6
  1. aidl_api/
  2. apex/
  3. binder/
  4. include/
  5. tests/
  6. .clang-format ⇨ ../../../build/soong/scripts/system-clang-format
  7. .editorconfig
  8. Android.bp
  9. Dns64Configuration.cpp
  10. Dns64Configuration.h
  11. DnsProxyListener.cpp
  12. DnsProxyListener.h
  13. DnsResolver.cpp
  14. DnsResolver.h
  15. DnsResolverService.cpp
  16. DnsResolverService.h
  17. DnsStats.cpp
  18. DnsStats.h
  19. DnsStatsTest.cpp
  20. DnsTlsDispatcher.cpp
  21. DnsTlsDispatcher.h
  22. DnsTlsQueryMap.cpp
  23. DnsTlsQueryMap.h
  24. DnsTlsServer.cpp
  25. DnsTlsServer.h
  26. DnsTlsSessionCache.cpp
  27. DnsTlsSessionCache.h
  28. DnsTlsSocket.cpp
  29. DnsTlsSocket.h
  30. DnsTlsSocketFactory.h
  31. DnsTlsTransport.cpp
  32. DnsTlsTransport.h
  33. getaddrinfo.cpp
  34. getaddrinfo.h
  35. gethnamaddr.cpp
  36. gethnamaddr.h
  37. hostent.h
  38. IDnsTlsSocket.h
  39. IDnsTlsSocketFactory.h
  40. IDnsTlsSocketObserver.h
  41. libnetd_resolv.map.txt
  42. LockedQueue.h
  43. NOTICE
  44. OWNERS
  45. params.h
  46. PREUPLOAD.cfg
  47. PrivateDnsConfiguration.cpp
  48. PrivateDnsConfiguration.h
  49. README-DoT.md
  50. README.md
  51. res_cache.cpp
  52. res_comp.cpp
  53. res_debug.cpp
  54. res_debug.h
  55. res_init.cpp
  56. res_init.h
  57. res_mkquery.cpp
  58. res_query.cpp
  59. res_send.cpp
  60. res_send.h
  61. res_stats.cpp
  62. resolv_cache.h
  63. resolv_cache_unit_test.cpp
  64. resolv_private.h
  65. resolv_tls_unit_test.cpp
  66. resolv_unit_test.cpp
  67. ResolverController.cpp
  68. ResolverController.h
  69. ResolverEventReporter.cpp
  70. ResolverEventReporter.h
  71. ResolverStats.h
  72. sethostent.cpp
  73. stats.h
  74. stats.proto
  75. TEST_MAPPING
  76. util.cpp
  77. util.h
README.md

Logging

This code uses LOG(X) for logging. Log levels are VERBOSE,DEBUG,INFO,WARNING and ERROR. The default setting is WARNING and logs relate to WARNING and ERROR will be shown. If you want to enable the DEBUG level logs, using following command. adb shell service call dnsresolver 10 i32 1 VERBOSE 0 DEBUG 1 INFO 2 WARNING 3 ERROR 4 Verbose resolver logs could contain PII -- do NOT enable in production builds.