Gitiles
Code Review Sign In
review.blissroms.org / platform_packages_modules_DnsResolver / 7d2fbb81a3f1282cf5db503e66772d1f0c86d872
commit7d2fbb81a3f1282cf5db503e66772d1f0c86d872[log] [tgz]
authorLuke Huang <huangluke@google.com>Wed Apr 14 14:28:05 2021 +0800
committerLuke Huang <huangluke@google.com>Thu Apr 15 12:59:46 2021 +0000
treedef8e2f3947cb6e201a2f2c932dddabe69896998
parent72799f37c67ec1273b740dd37061772988f093a7 [diff]
Fix the unexpected getaddrinfo error code changing due to parallel lookup

Parallel lookup unexpectedly changed the error code when the queries are
blocked by system.
2 problems here,
    1. the errno from query thread isn't correctly propagated to the main
thread.
    2. The rcode handling is changed.
Fix them in this CL and also add a test for this problem.

Bug: 185097438
Test: atest
Change-Id: I4c8e2895baa9d3d8ece40fe7bb8c3975672997a4
2 files changed
tree: def8e2f3947cb6e201a2f2c932dddabe69896998
  1. aidl_api/
  2. apex/
  3. binder/
  4. include/
  5. tests/
  6. .clang-format ⇨ ../../../build/soong/scripts/system-clang-format
  7. rustfmt.toml ⇨ ../../../build/soong/scripts/rustfmt.toml
  8. .editorconfig
  9. Android.bp
  10. cbindgen.toml
  11. Dns64Configuration.cpp
  12. Dns64Configuration.h
  13. DnsProxyListener.cpp
  14. DnsProxyListener.h
  15. DnsQueryLog.cpp
  16. DnsQueryLog.h
  17. DnsQueryLogTest.cpp
  18. DnsResolver.cpp
  19. DnsResolver.h
  20. DnsResolverService.cpp
  21. DnsResolverService.h
  22. DnsStats.cpp
  23. DnsStats.h
  24. DnsStatsTest.cpp
  25. DnsTlsDispatcher.cpp
  26. DnsTlsDispatcher.h
  27. DnsTlsQueryMap.cpp
  28. DnsTlsQueryMap.h
  29. DnsTlsServer.cpp
  30. DnsTlsServer.h
  31. DnsTlsSessionCache.cpp
  32. DnsTlsSessionCache.h
  33. DnsTlsSocket.cpp
  34. DnsTlsSocket.h
  35. DnsTlsSocketFactory.h
  36. DnsTlsTransport.cpp
  37. DnsTlsTransport.h
  38. doh.h
  39. doh.rs
  40. doh_ffi_test.cpp
  41. Experiments.cpp
  42. Experiments.h
  43. ExperimentsTest.cpp
  44. getaddrinfo.cpp
  45. getaddrinfo.h
  46. gethnamaddr.cpp
  47. gethnamaddr.h
  48. hostent.h
  49. IDnsTlsSocket.h
  50. IDnsTlsSocketFactory.h
  51. IDnsTlsSocketObserver.h
  52. libnetd_resolv.map.txt
  53. LockedQueue.h
  54. NOTICE
  55. OperationLimiter.h
  56. OperationLimiterTest.cpp
  57. OWNERS
  58. params.h
  59. PREUPLOAD.cfg
  60. PrivateDnsCommon.h
  61. PrivateDnsConfiguration.cpp
  62. PrivateDnsConfiguration.h
  63. PrivateDnsConfigurationTest.cpp
  64. PrivateDnsValidationObserver.h
  65. README-DoT.md
  66. README.md
  67. res_cache.cpp
  68. res_comp.cpp
  69. res_comp.h
  70. res_debug.cpp
  71. res_debug.h
  72. res_mkquery.cpp
  73. res_query.cpp
  74. res_send.cpp
  75. res_send.h
  76. res_stats.cpp
  77. resolv_cache.h
  78. resolv_private.h
  79. resolv_test_config_template.xml
  80. ResolverController.cpp
  81. ResolverController.h
  82. ResolverEventReporter.cpp
  83. ResolverEventReporter.h
  84. ResolverStats.h
  85. sethostent.cpp
  86. stats.h
  87. stats.proto
  88. TEST_MAPPING
  89. util.cpp
  90. util.h
README.md

Logging

This code uses LOG(X) for logging. Log levels are VERBOSE,DEBUG,INFO,WARNING and ERROR. The default setting is WARNING and logs relate to WARNING and ERROR will be shown. If you want to enable the DEBUG level logs, using following command. adb shell service call dnsresolver 10 i32 1 VERBOSE 0 DEBUG 1 INFO 2 WARNING 3 ERROR 4 Verbose resolver logs could contain PII -- do NOT enable in production builds.