Gitiles
Code Review Sign In
review.blissroms.org / platform_packages_modules_adb / 3a5c314961a17ec07ce108435d941c2e4f8d450b
commit3a5c314961a17ec07ce108435d941c2e4f8d450b[log] [tgz]
authorTing-Yuan Huang <laszio@google.com>Wed Oct 19 18:15:30 2016 -0700
committerGeorge Burgess IV <gbiv@google.com>Wed Oct 19 19:39:44 2016 -0700
treec022f641ea1b9c00525ead95428b39042d2fc519
parentc75f65f4e32a5bb79038e559bbb8c05732270255 [diff]
adb: fix undefined behavior

system/core/adb/shell_service_protocol_test.cpp:94:14: warning: Null
passed to a callee that requires a non-null 1st parameter
            !memcmp(data, protocol->data(), data_length));

C99 requires memcmp() to take non-null pointers.

Bug: none
Test: clang-tidy doesn't complain
Change-Id: I77b8d9373fa257a070ffc7fd318231c2c9ea84c3
1 file changed
tree: c022f641ea1b9c00525ead95428b39042d2fc519
  1. client/
  2. daemon/
  3. sysdeps/
  4. .clang-format
  5. adb.cpp
  6. adb.h
  7. adb_auth.h
  8. adb_auth_host.cpp
  9. adb_client.cpp
  10. adb_client.h
  11. adb_io.cpp
  12. adb_io.h
  13. adb_io_test.cpp
  14. adb_listeners.cpp
  15. adb_listeners.h
  16. adb_listeners_test.cpp
  17. adb_trace.cpp
  18. adb_trace.h
  19. adb_unique_fd.h
  20. adb_utils.cpp
  21. adb_utils.h
  22. adb_utils_test.cpp
  23. adbd_auth.cpp
  24. Android.mk
  25. bugreport.cpp
  26. bugreport.h
  27. bugreport_test.cpp
  28. commandline.cpp
  29. commandline.h
  30. console.cpp
  31. CPPLINT.cfg
  32. diagnose_usb.cpp
  33. diagnose_usb.h
  34. fdevent.cpp
  35. fdevent.h
  36. fdevent_test.cpp
  37. fdevent_test.h
  38. file_sync_client.cpp
  39. file_sync_service.cpp
  40. file_sync_service.h
  41. framebuffer_service.cpp
  42. jdwp_service.cpp
  43. line_printer.cpp
  44. line_printer.h
  45. MODULE_LICENSE_APACHE2
  46. NOTICE
  47. OVERVIEW.TXT
  48. protocol.txt
  49. remount_service.cpp
  50. remount_service.h
  51. security_log_tags.h
  52. services.cpp
  53. services.h
  54. SERVICES.TXT
  55. set_verity_enable_state_service.cpp
  56. shell_service.cpp
  57. shell_service.h
  58. shell_service_protocol.cpp
  59. shell_service_protocol_test.cpp
  60. shell_service_test.cpp
  61. socket.h
  62. socket_spec.cpp
  63. socket_spec.h
  64. socket_spec_test.cpp
  65. socket_test.cpp
  66. sockets.cpp
  67. sockets.dia
  68. SYNC.TXT
  69. sysdeps.h
  70. sysdeps_test.cpp
  71. sysdeps_unix.cpp
  72. sysdeps_win32.cpp
  73. sysdeps_win32_test.cpp
  74. test_adb.py
  75. test_device.py
  76. transport.cpp
  77. transport.h
  78. transport_local.cpp
  79. transport_test.cpp
  80. transport_usb.cpp
  81. usb_linux.cpp
  82. usb_linux_client.cpp
  83. usb_osx.cpp
  84. usb_windows.cpp