Gitiles
Code Review Sign In
review.blissroms.org / platform_packages_modules_adb / fa3107e2477de7b7554816ac5e2edeeef058e1b6
commitfa3107e2477de7b7554816ac5e2edeeef058e1b6[log] [tgz]
authorJosh Gao <jmgao@google.com>Wed Jul 25 17:21:49 2018 -0700
committerJosh Gao <jmgao@google.com>Wed Jul 25 18:49:37 2018 -0700
treed07cb6886f12b3ef7696b79a157e5df2dabea2be
parentd8d51f4fc05fe76d463812be51916ad786570f02 [diff]
adb: fix register_socket_transport related double-closes.

Multiple codepaths were closing the fd they passed into
register_socket_transport on failure, which would close the fd itself.

Switch things over to unique_fd to make it clear that we don't actually
have to close on failure.

Test: mma
Change-Id: I2d9bdcb1142c24931d970f99ebdf9a8051daf05c
4 files changed
tree: d07cb6886f12b3ef7696b79a157e5df2dabea2be
  1. client/
  2. daemon/
  3. sysdeps/
  4. .clang-format ⇨ ../.clang-format-4
  5. adb.bash
  6. adb.cpp
  7. adb.h
  8. adb_auth.h
  9. adb_io.cpp
  10. adb_io.h
  11. adb_io_test.cpp
  12. adb_listeners.cpp
  13. adb_listeners.h
  14. adb_listeners_test.cpp
  15. adb_mdns.h
  16. adb_trace.cpp
  17. adb_trace.h
  18. adb_unique_fd.cpp
  19. adb_unique_fd.h
  20. adb_utils.cpp
  21. adb_utils.h
  22. adb_utils_test.cpp
  23. Android.bp
  24. Android.mk
  25. benchmark_device.py
  26. bugreport_test.cpp
  27. fdevent.cpp
  28. fdevent.h
  29. fdevent_test.cpp
  30. fdevent_test.h
  31. file_sync_protocol.h
  32. MODULE_LICENSE_APACHE2
  33. NOTICE
  34. OVERVIEW.TXT
  35. OWNERS
  36. protocol.txt
  37. security_log_tags.h
  38. services.cpp
  39. services.h
  40. SERVICES.TXT
  41. shell_protocol.h
  42. shell_service_protocol.cpp
  43. shell_service_protocol_test.cpp
  44. socket.h
  45. socket_spec.cpp
  46. socket_spec.h
  47. socket_spec_test.cpp
  48. socket_test.cpp
  49. sockets.cpp
  50. sockets.dia
  51. SYNC.TXT
  52. sysdeps.h
  53. sysdeps_test.cpp
  54. sysdeps_unix.cpp
  55. sysdeps_win32.cpp
  56. sysdeps_win32_test.cpp
  57. test_adb.py
  58. test_device.py
  59. trace.sh
  60. transport.cpp
  61. transport.h
  62. transport_benchmark.cpp
  63. transport_fd.cpp
  64. transport_local.cpp
  65. transport_test.cpp
  66. transport_usb.cpp
  67. types.h
  68. types_test.cpp
  69. usb.h