Gitiles
Code Review Sign In
review.blissroms.org / platform_packages_modules_adb / da537075677d85a6c3614020ee2fed893d191534
commitda537075677d85a6c3614020ee2fed893d191534[log] [tgz]
authorJoshua Duong <joshuaduong@google.com>Mon Jun 29 16:27:03 2020 -0700
committerJoshua Duong <joshuaduong@google.com>Wed Jul 01 15:06:33 2020 -0700
treed9322594fba265d211890ccb143a5730ddfc76ad
parentd7bae8bccd3ec5846766af96d28eec7b050ae420 [diff]
[adb] Fix crash in mdns service removal.

If std::remove_if is a no-op (no service name match), then
std::vector::erase would crash.

Bug: 160025305

Test: test_adb.py
Test: Manual.
1) Enable wireless debugging on multiple devices
2) Disable wireless debugging on all devices

Change-Id: If58b0dda0bb698fd3fd225d9b6a6726a88ae47e0
2 files changed
tree: d9322594fba265d211890ccb143a5730ddfc76ad
  1. apex/
  2. client/
  3. coverage/
  4. crypto/
  5. daemon/
  6. fastdeploy/
  7. fdevent/
  8. libs/
  9. pairing_auth/
  10. pairing_connection/
  11. proto/
  12. sysdeps/
  13. tls/
  14. tools/
  15. .clang-format ⇨ ../.clang-format-4
  16. adb.bash
  17. adb.cpp
  18. adb.h
  19. adb_auth.h
  20. adb_integration_test_adb.xml
  21. adb_integration_test_device.xml
  22. adb_io.cpp
  23. adb_io.h
  24. adb_io_test.cpp
  25. adb_listeners.cpp
  26. adb_listeners.h
  27. adb_listeners_test.cpp
  28. adb_mdns.h
  29. adb_trace.cpp
  30. adb_trace.h
  31. adb_unique_fd.cpp
  32. adb_unique_fd.h
  33. adb_utils.cpp
  34. adb_utils.h
  35. adb_utils_test.cpp
  36. adb_wifi.h
  37. Android.bp
  38. benchmark_device.py
  39. bugreport_test.cpp
  40. compression_utils.h
  41. file_sync_protocol.h
  42. mdns_test.cpp
  43. MODULE_LICENSE_APACHE2
  44. NOTICE
  45. OVERVIEW.TXT
  46. OWNERS
  47. protocol.txt
  48. security_log_tags.h
  49. services.cpp
  50. services.h
  51. SERVICES.TXT
  52. shell_protocol.h
  53. shell_service_protocol.cpp
  54. shell_service_protocol_test.cpp
  55. SOCKET-ACTIVATION.txt
  56. socket.h
  57. socket_spec.cpp
  58. socket_spec.h
  59. socket_spec_test.cpp
  60. socket_test.cpp
  61. sockets.cpp
  62. sockets.dia
  63. SYNC.TXT
  64. sysdeps.h
  65. sysdeps_test.cpp
  66. sysdeps_unix.cpp
  67. sysdeps_win32.cpp
  68. sysdeps_win32_test.cpp
  69. test_adb.py
  70. test_device.py
  71. trace.sh
  72. transport.cpp
  73. transport.h
  74. transport_benchmark.cpp
  75. transport_fd.cpp
  76. transport_test.cpp
  77. types.cpp
  78. types.h
  79. types_test.cpp