Gitiles
Code Review Sign In
review.blissroms.org / platform_packages_modules_adb / 2ca07b0466d3fd22bf46df131fee8c6b414e89c3
commit2ca07b0466d3fd22bf46df131fee8c6b414e89c3[log] [tgz]
authorElliott Hughes <enh@google.com>Mon May 04 19:29:32 2015 -0700
committerElliott Hughes <enh@google.com>Tue May 05 12:45:42 2015 -0700
treef2c622b9e371ad855d28588a5c99907ce870512a
parent37f83ed4c8930b1241834d17b5d75dbf2d3f4368 [diff]
Implement the ssh(1) escaping rules.

The first rule of ssh(1) escaping is that there is no escaping.

This doesn't undo any of my recent security fixes because they're all
calling escape_arg themselves.

This fixes "adb shell rm /data/dalvik-cache/arm/*".

Also remove do_cmd which caused concern during code review.

Bug: http://b/20564385
Change-Id: I4588fd949d51e2a50cff47ea171ed2d75f402d0d
(cherry picked from commit eaabdd67f30600cbd329cd583ecff3ced34a55ba)
2 files changed
tree: f2c622b9e371ad855d28588a5c99907ce870512a
  1. tests/
  2. .clang-format
  3. adb.cpp
  4. adb.h
  5. adb_auth.cpp
  6. adb_auth.h
  7. adb_auth_client.cpp
  8. adb_auth_host.cpp
  9. adb_client.cpp
  10. adb_client.h
  11. adb_io.cpp
  12. adb_io.h
  13. adb_io_test.cpp
  14. adb_listeners.cpp
  15. adb_listeners.h
  16. adb_main.cpp
  17. adb_trace.h
  18. adb_utils.cpp
  19. adb_utils.h
  20. adb_utils_test.cpp
  21. Android.mk
  22. commandline.cpp
  23. console.cpp
  24. CPPLINT.cfg
  25. fdevent.cpp
  26. fdevent.h
  27. file_sync_client.cpp
  28. file_sync_service.cpp
  29. file_sync_service.h
  30. framebuffer_service.cpp
  31. get_my_path_darwin.cpp
  32. get_my_path_linux.cpp
  33. get_my_path_windows.cpp
  34. jdwp_service.cpp
  35. MODULE_LICENSE_APACHE2
  36. mutex_list.h
  37. NOTICE
  38. OVERVIEW.TXT
  39. protocol.txt
  40. qemu_tracing.cpp
  41. qemu_tracing.h
  42. remount_service.cpp
  43. remount_service.h
  44. services.cpp
  45. SERVICES.TXT
  46. set_verity_enable_state_service.cpp
  47. sockets.cpp
  48. sockets.dia
  49. SYNC.TXT
  50. sysdeps.h
  51. sysdeps_win32.cpp
  52. test_track_devices.cpp
  53. transport.cpp
  54. transport.h
  55. transport_local.cpp
  56. transport_test.cpp
  57. transport_usb.cpp
  58. usb_linux.cpp
  59. usb_linux_client.cpp
  60. usb_osx.cpp
  61. usb_windows.cpp