Gitiles
Code Review Sign In
review.blissroms.org / platform_packages_modules_adb / 9a9827fe48e025a9f62ac372c7da92223af02d22
commit9a9827fe48e025a9f62ac372c7da92223af02d22[log] [tgz]
authorSpencer Low <CompareAndSwap@gmail.com>Wed Feb 10 15:03:50 2016 -0800
committerJosh Gao <jmgao@google.com>Mon Feb 22 15:57:08 2016 -0800
treeb32e82ceb7ca2b24f60e9f9cfde7c30b27a7b595
parent9efe32161843994c2486e7875f466a7c2bfb9c24 [diff]
adb: mkdirs fixes

Fix pathological case where the directory to be created can't be created
because there is already a file there. This was previously returning
success because the wrong var was passed to directory_exists().

Fix test to exercise this situation. Also clarify tests.

Change-Id: I0dc0f14084e0eda4e1498874d4ab2a6445d322ac
Signed-off-by: Spencer Low <CompareAndSwap@gmail.com>
(cherry picked from commit 1ec9ceb6eea5e6c5657ddcad5fc32bcaa52c9620)
2 files changed
tree: b32e82ceb7ca2b24f60e9f9cfde7c30b27a7b595
  1. client/
  2. daemon/
  3. .clang-format
  4. adb.cpp
  5. adb.h
  6. adb_auth.cpp
  7. adb_auth.h
  8. adb_auth_client.cpp
  9. adb_auth_host.cpp
  10. adb_client.cpp
  11. adb_client.h
  12. adb_io.cpp
  13. adb_io.h
  14. adb_io_test.cpp
  15. adb_listeners.cpp
  16. adb_listeners.h
  17. adb_trace.cpp
  18. adb_trace.h
  19. adb_utils.cpp
  20. adb_utils.h
  21. adb_utils_test.cpp
  22. Android.mk
  23. commandline.cpp
  24. console.cpp
  25. CPPLINT.cfg
  26. diagnose_usb.cpp
  27. diagnose_usb.h
  28. fdevent.cpp
  29. fdevent.h
  30. fdevent_test.cpp
  31. file_sync_client.cpp
  32. file_sync_service.cpp
  33. file_sync_service.h
  34. framebuffer_service.cpp
  35. get_my_path_darwin.cpp
  36. get_my_path_linux.cpp
  37. jdwp_service.cpp
  38. line_printer.cpp
  39. line_printer.h
  40. MODULE_LICENSE_APACHE2
  41. mutex_list.h
  42. NOTICE
  43. OVERVIEW.TXT
  44. protocol.txt
  45. remount_service.cpp
  46. remount_service.h
  47. security_log_tags.h
  48. services.cpp
  49. services.h
  50. SERVICES.TXT
  51. set_verity_enable_state_service.cpp
  52. shell_service.cpp
  53. shell_service.h
  54. shell_service_protocol.cpp
  55. shell_service_protocol_test.cpp
  56. shell_service_test.cpp
  57. socket.h
  58. socket_test.cpp
  59. sockets.cpp
  60. sockets.dia
  61. SYNC.TXT
  62. sysdeps.h
  63. sysdeps_test.cpp
  64. sysdeps_win32.cpp
  65. sysdeps_win32_test.cpp
  66. test_adb.py
  67. test_device.py
  68. test_track_devices.cpp
  69. transport.cpp
  70. transport.h
  71. transport_local.cpp
  72. transport_test.cpp
  73. transport_usb.cpp
  74. usb_linux.cpp
  75. usb_linux_client.cpp
  76. usb_osx.cpp
  77. usb_windows.cpp