Gitiles
Code Review Sign In
review.blissroms.org / platform_packages_modules_adb / b77fc72a5fd45b78c161d324b05895207bfee83c
commitb77fc72a5fd45b78c161d324b05895207bfee83c[log] [tgz]
authorSpencer Low <CompareAndSwap@gmail.com>Wed Sep 16 16:40:06 2015 -0700
committerSpencer Low <CompareAndSwap@gmail.com>Wed Sep 16 16:40:06 2015 -0700
treeb6feba1ffae67695187f0533388c187ee6fdf78a
parent4d4961f418cec8639a90ed23ada89f84eff5c6ec [diff]
adb: win32: fix regression on older versions of Windows

On Windows 7, GetStdHandle() may return console pseudo-handles. If you
call SetHandleInformation(h, HANDLE_FLAG_INHERIT, 0) on such a handle,
it will fail. These failures should be ignored like the old code.

Newer versions of Windows return real handles that don't have this
issue. Console pseudo-handles can apparently be identified by the values
3, 7, 11.

This is a regression from 2bbb3a9fa2fa2b331e04b2c296ed9a10c0b55669.

https://code.google.com/p/android/issues/detail?id=186599

Change-Id: I287a74a81d37e0ebe62d673a3f5651ee5439c0d2
Signed-off-by: Spencer Low <CompareAndSwap@gmail.com>
1 file changed
tree: b6feba1ffae67695187f0533388c187ee6fdf78a
  1. client/
  2. daemon/
  3. .clang-format
  4. __init__.py
  5. adb.cpp
  6. adb.h
  7. adb_auth.cpp
  8. adb_auth.h
  9. adb_auth_client.cpp
  10. adb_auth_host.cpp
  11. adb_client.cpp
  12. adb_client.h
  13. adb_io.cpp
  14. adb_io.h
  15. adb_io_test.cpp
  16. adb_listeners.cpp
  17. adb_listeners.h
  18. adb_trace.h
  19. adb_utils.cpp
  20. adb_utils.h
  21. adb_utils_test.cpp
  22. Android.mk
  23. commandline.cpp
  24. console.cpp
  25. CPPLINT.cfg
  26. device.py
  27. fdevent.cpp
  28. fdevent.h
  29. fdevent_test.cpp
  30. file_sync_client.cpp
  31. file_sync_service.cpp
  32. file_sync_service.h
  33. framebuffer_service.cpp
  34. get_my_path_darwin.cpp
  35. get_my_path_linux.cpp
  36. jdwp_service.cpp
  37. MODULE_LICENSE_APACHE2
  38. mutex_list.h
  39. NOTICE
  40. OVERVIEW.TXT
  41. protocol.txt
  42. remount_service.cpp
  43. remount_service.h
  44. services.cpp
  45. SERVICES.TXT
  46. set_verity_enable_state_service.cpp
  47. shell_service.cpp
  48. shell_service.h
  49. shell_service_protocol.cpp
  50. shell_service_protocol_test.cpp
  51. shell_service_test.cpp
  52. sockets.cpp
  53. sockets.dia
  54. SYNC.TXT
  55. sysdeps.h
  56. sysdeps_win32.cpp
  57. sysdeps_win32_test.cpp
  58. test_adb.py
  59. test_device.py
  60. test_track_devices.cpp
  61. transport.cpp
  62. transport.h
  63. transport_local.cpp
  64. transport_test.cpp
  65. transport_usb.cpp
  66. usb_linux.cpp
  67. usb_linux_client.cpp
  68. usb_osx.cpp
  69. usb_windows.cpp