Gitiles
Code Review Sign In
review.blissroms.org / platform_packages_modules_adb / ebe9970151e60988eecf288f03c00f42f0944312
commitebe9970151e60988eecf288f03c00f42f0944312[log] [tgz]
authorGeorge Burgess IV <gbiv@google.com>Sat Feb 17 21:43:55 2018 -0800
committerJosh Gao <jmgao@google.com>Mon Feb 19 01:05:56 2018 -0800
tree770b308b835bb974befef3496cdfd38aa2ea825e
parentf090647ceb026ef7acec3ba3fafae1bcb4b0ee68 [diff]
Fix a memory leak

If create_service_thread fails, we'll leak `arg`.

This fixes a static analyzer complaint:
system/core/adb/services.cpp:298:13: warning: Potential leak of memory
pointed to by 'arg'

Bug: None
Test: Reran the static analyzer. No more complaints about this leak.
Change-Id: I5aec7fd78f2cc775b650501b02bdf0039d1647ca
1 file changed
tree: 770b308b835bb974befef3496cdfd38aa2ea825e
  1. client/
  2. daemon/
  3. sysdeps/
  4. .clang-format ⇨ ../.clang-format-4
  5. adb.cpp
  6. adb.h
  7. adb_auth.h
  8. adb_auth_host.cpp
  9. adb_client.cpp
  10. adb_client.h
  11. adb_io.cpp
  12. adb_io.h
  13. adb_io_test.cpp
  14. adb_listeners.cpp
  15. adb_listeners.h
  16. adb_listeners_test.cpp
  17. adb_mdns.h
  18. adb_trace.cpp
  19. adb_trace.h
  20. adb_unique_fd.h
  21. adb_utils.cpp
  22. adb_utils.h
  23. adb_utils_test.cpp
  24. adbd_auth.cpp
  25. Android.bp
  26. Android.mk
  27. bugreport.cpp
  28. bugreport.h
  29. bugreport_test.cpp
  30. commandline.cpp
  31. commandline.h
  32. console.cpp
  33. CPPLINT.cfg
  34. diagnose_usb.cpp
  35. diagnose_usb.h
  36. fdevent.cpp
  37. fdevent.h
  38. fdevent_test.cpp
  39. fdevent_test.h
  40. file_sync_client.cpp
  41. file_sync_service.cpp
  42. file_sync_service.h
  43. framebuffer_service.cpp
  44. jdwp_service.cpp
  45. line_printer.cpp
  46. line_printer.h
  47. MODULE_LICENSE_APACHE2
  48. NOTICE
  49. OVERVIEW.TXT
  50. OWNERS
  51. protocol.txt
  52. range.h
  53. remount_service.cpp
  54. remount_service.h
  55. security_log_tags.h
  56. services.cpp
  57. services.h
  58. SERVICES.TXT
  59. set_verity_enable_state_service.cpp
  60. shell_service.cpp
  61. shell_service.h
  62. shell_service_protocol.cpp
  63. shell_service_protocol_test.cpp
  64. shell_service_test.cpp
  65. socket.h
  66. socket_spec.cpp
  67. socket_spec.h
  68. socket_spec_test.cpp
  69. socket_test.cpp
  70. sockets.cpp
  71. sockets.dia
  72. SYNC.TXT
  73. sysdeps.h
  74. sysdeps_test.cpp
  75. sysdeps_unix.cpp
  76. sysdeps_win32.cpp
  77. sysdeps_win32_test.cpp
  78. test_adb.py
  79. test_device.py
  80. trace.sh
  81. transport.cpp
  82. transport.h
  83. transport_local.cpp
  84. transport_mdns.cpp
  85. transport_mdns_unsupported.cpp
  86. transport_test.cpp
  87. transport_usb.cpp
  88. usb.h