Gitiles
Code Review Sign In
review.blissroms.org / platform_packages_modules_adb / ce6d3a5b021a8da22bbf732b9e72de21a667830a
commitce6d3a5b021a8da22bbf732b9e72de21a667830a[log] [tgz]
authorJosh Gao <jmgao@google.com>Thu Sep 26 01:49:56 2019 +0800
committerJosh Gao <jmgao@google.com>Thu Sep 26 01:56:58 2019 +0800
tree7543d7b8cf1a1aa8cd547ae5819b8b63f9ee6b57
parent68e61928b63ae46d26013a617ff843b8d274b6fe [diff]
adb: fix infinite loop when attempting to push to //foo.

dirname (on glibc, at least) preserves multiple leading slashes, and we
were looping until path != "/", which would lead to an infinite loop
when attempting to push to a path like //data/local/tmp.

Bug: http://b/141311284
Test: python -m unittest test_device.FileOperationsTest.test_push_multiple_slash_root
Change-Id: I182b3e89ef52579c716fdb525e9215f1fe822477
2 files changed
tree: 7543d7b8cf1a1aa8cd547ae5819b8b63f9ee6b57
  1. client/
  2. daemon/
  3. fastdeploy/
  4. fdevent/
  5. sysdeps/
  6. tools/
  7. .clang-format ⇨ ../.clang-format-4
  8. adb.bash
  9. adb.cpp
  10. adb.h
  11. adb_auth.h
  12. adb_integration_test_adb.xml
  13. adb_integration_test_device.xml
  14. adb_io.cpp
  15. adb_io.h
  16. adb_io_test.cpp
  17. adb_listeners.cpp
  18. adb_listeners.h
  19. adb_listeners_test.cpp
  20. adb_mdns.h
  21. adb_trace.cpp
  22. adb_trace.h
  23. adb_unique_fd.cpp
  24. adb_unique_fd.h
  25. adb_utils.cpp
  26. adb_utils.h
  27. adb_utils_test.cpp
  28. Android.bp
  29. benchmark_device.py
  30. bugreport_test.cpp
  31. file_sync_protocol.h
  32. MODULE_LICENSE_APACHE2
  33. NOTICE
  34. OVERVIEW.TXT
  35. OWNERS
  36. protocol.txt
  37. security_log_tags.h
  38. services.cpp
  39. services.h
  40. SERVICES.TXT
  41. shell_protocol.h
  42. shell_service_protocol.cpp
  43. shell_service_protocol_test.cpp
  44. socket.h
  45. socket_spec.cpp
  46. socket_spec.h
  47. socket_spec_test.cpp
  48. socket_test.cpp
  49. sockets.cpp
  50. sockets.dia
  51. SYNC.TXT
  52. sysdeps.h
  53. sysdeps_test.cpp
  54. sysdeps_unix.cpp
  55. sysdeps_win32.cpp
  56. sysdeps_win32_test.cpp
  57. test_adb.py
  58. test_device.py
  59. trace.sh
  60. transport.cpp
  61. transport.h
  62. transport_benchmark.cpp
  63. transport_fd.cpp
  64. transport_local.cpp
  65. transport_test.cpp
  66. transport_usb.cpp
  67. types.h
  68. types_test.cpp
  69. usb.h