Gitiles
Code Review Sign In
review.blissroms.org / platform_packages_modules_adb / e490fbb200ddc444667d4a701437c9292de797bb
commite490fbb200ddc444667d4a701437c9292de797bb[log] [tgz]
authorJosh Gao <jmgao@google.com>Mon Dec 09 15:44:57 2019 -0800
committerJosh Gao <jmgao@google.com>Fri Dec 13 13:28:21 2019 -0800
treef3bddb64f36507476f1b747492c0a2f4f462263f
parent26fdcedbd2fdc46513ff5efaa1752ecad3bb1d8e [diff]
adb: fix use after free of atransport.

libadbd_auth might report authentication success for a transport that's
already been destroyed. Fix this by storing a weak pointer to the
atransport that gets cleared upon destruction instead of a raw pointer.

Bug: http://b/144704376
Test: ./test_adb.py
Test: ./test_device.py
Change-Id: Idffe027381e6b2e37f06aa0166e97cafc98eaf3b
3 files changed
tree: f3bddb64f36507476f1b747492c0a2f4f462263f
  1. apex/
  2. client/
  3. daemon/
  4. fastdeploy/
  5. fdevent/
  6. sysdeps/
  7. tools/
  8. .clang-format ⇨ ../.clang-format-4
  9. adb.bash
  10. adb.cpp
  11. adb.h
  12. adb_auth.h
  13. adb_integration_test_adb.xml
  14. adb_integration_test_device.xml
  15. adb_io.cpp
  16. adb_io.h
  17. adb_io_test.cpp
  18. adb_listeners.cpp
  19. adb_listeners.h
  20. adb_listeners_test.cpp
  21. adb_mdns.h
  22. adb_trace.cpp
  23. adb_trace.h
  24. adb_unique_fd.cpp
  25. adb_unique_fd.h
  26. adb_utils.cpp
  27. adb_utils.h
  28. adb_utils_test.cpp
  29. Android.bp
  30. benchmark_device.py
  31. bugreport_test.cpp
  32. file_sync_protocol.h
  33. MODULE_LICENSE_APACHE2
  34. NOTICE
  35. OVERVIEW.TXT
  36. OWNERS
  37. protocol.txt
  38. security_log_tags.h
  39. services.cpp
  40. services.h
  41. SERVICES.TXT
  42. shell_protocol.h
  43. shell_service_protocol.cpp
  44. shell_service_protocol_test.cpp
  45. SOCKET-ACTIVATION.txt
  46. socket.h
  47. socket_spec.cpp
  48. socket_spec.h
  49. socket_spec_test.cpp
  50. socket_test.cpp
  51. sockets.cpp
  52. sockets.dia
  53. SYNC.TXT
  54. sysdeps.h
  55. sysdeps_test.cpp
  56. sysdeps_unix.cpp
  57. sysdeps_win32.cpp
  58. sysdeps_win32_test.cpp
  59. test_adb.py
  60. test_device.py
  61. trace.sh
  62. transport.cpp
  63. transport.h
  64. transport_benchmark.cpp
  65. transport_fd.cpp
  66. transport_local.cpp
  67. transport_test.cpp
  68. transport_usb.cpp
  69. types.cpp
  70. types.h
  71. types_test.cpp
  72. usb.h