Gitiles
Code Review Sign In
review.blissroms.org / platform_packages_modules_adb / e5e6b0d89d8e2d9b32c0bd33298fe8de037b171b
commite5e6b0d89d8e2d9b32c0bd33298fe8de037b171b[log] [tgz]
authorYurii Zubrytskyi <zyy@google.com>Fri Jul 12 14:11:54 2019 -0700
committerJosh Gao <jmgao@google.com>Thu Nov 28 18:24:01 2019 -0800
treed29985efba87814160d22f646f3b3458a7c91a5c
parentdcea54ce982a0a757199340611365b608a54c6fe [diff]
[adb] Optimize adbd's usb reading

Try to not allocate as many blocks on the heap, and reuse
memory instead of copying it

Get rid of unique_ptr and shared_ptr where possible, move
the Block objects themselves

Overall this reduces the time spent in memcpy() from 30% to
15% of the whole 'adb push' command, and gets rid of about 5%
of the time spent in the malloc/free calls

Test: builds
Change-Id: I8995115274b6f08a4df13c58183c928ef384a767
7 files changed
tree: d29985efba87814160d22f646f3b3458a7c91a5c
  1. apex/
  2. client/
  3. daemon/
  4. fastdeploy/
  5. fdevent/
  6. sysdeps/
  7. tools/
  8. .clang-format ⇨ ../.clang-format-4
  9. adb.bash
  10. adb.cpp
  11. adb.h
  12. adb_auth.h
  13. adb_integration_test_adb.xml
  14. adb_integration_test_device.xml
  15. adb_io.cpp
  16. adb_io.h
  17. adb_io_test.cpp
  18. adb_listeners.cpp
  19. adb_listeners.h
  20. adb_listeners_test.cpp
  21. adb_mdns.h
  22. adb_trace.cpp
  23. adb_trace.h
  24. adb_unique_fd.cpp
  25. adb_unique_fd.h
  26. adb_utils.cpp
  27. adb_utils.h
  28. adb_utils_test.cpp
  29. Android.bp
  30. benchmark_device.py
  31. bugreport_test.cpp
  32. file_sync_protocol.h
  33. MODULE_LICENSE_APACHE2
  34. NOTICE
  35. OVERVIEW.TXT
  36. OWNERS
  37. protocol.txt
  38. security_log_tags.h
  39. services.cpp
  40. services.h
  41. SERVICES.TXT
  42. shell_protocol.h
  43. shell_service_protocol.cpp
  44. shell_service_protocol_test.cpp
  45. socket.h
  46. socket_spec.cpp
  47. socket_spec.h
  48. socket_spec_test.cpp
  49. socket_test.cpp
  50. sockets.cpp
  51. sockets.dia
  52. SYNC.TXT
  53. sysdeps.h
  54. sysdeps_test.cpp
  55. sysdeps_unix.cpp
  56. sysdeps_win32.cpp
  57. sysdeps_win32_test.cpp
  58. test_adb.py
  59. test_device.py
  60. trace.sh
  61. transport.cpp
  62. transport.h
  63. transport_benchmark.cpp
  64. transport_fd.cpp
  65. transport_local.cpp
  66. transport_test.cpp
  67. transport_usb.cpp
  68. types.cpp
  69. types.h
  70. types_test.cpp
  71. usb.h