Gitiles
Code Review Sign In
review.blissroms.org / platform_packages_modules_adb / e98825e827267a4afa40f13c32d5aa24f3c100d5
commite98825e827267a4afa40f13c32d5aa24f3c100d5[log] [tgz]
authorSpencer Low <CompareAndSwap@gmail.com>Mon Sep 07 16:20:13 2015 -0700
committerSpencer Low <CompareAndSwap@gmail.com>Mon Sep 07 16:20:13 2015 -0700
treeb885c045f4b94d2874ab393c1c8d598ace68c4a4
parent38e289fa08f56a84267132266f7c2a8ea81830cc [diff]
adb: refactor _is_valid_ack_reply_fd

Visual Studio's 'jump to reference' feature couldn't parse
adb_commandline() because I used an #ifdef in the middle of an if
statement, so this refactors the code into a separate helper function. I
just copied the code and inverted the comparisons.

No need for sysdeps since this is pretty minor.

Change-Id: Ifd5c62b0b505080ada6db5cc19739c6f07b94de9
Signed-off-by: Spencer Low <CompareAndSwap@gmail.com>
1 file changed
tree: b885c045f4b94d2874ab393c1c8d598ace68c4a4
  1. client/
  2. daemon/
  3. .clang-format
  4. __init__.py
  5. adb.cpp
  6. adb.h
  7. adb_auth.cpp
  8. adb_auth.h
  9. adb_auth_client.cpp
  10. adb_auth_host.cpp
  11. adb_client.cpp
  12. adb_client.h
  13. adb_io.cpp
  14. adb_io.h
  15. adb_io_test.cpp
  16. adb_listeners.cpp
  17. adb_listeners.h
  18. adb_trace.h
  19. adb_utils.cpp
  20. adb_utils.h
  21. adb_utils_test.cpp
  22. Android.mk
  23. commandline.cpp
  24. console.cpp
  25. CPPLINT.cfg
  26. device.py
  27. fdevent.cpp
  28. fdevent.h
  29. fdevent_test.cpp
  30. file_sync_client.cpp
  31. file_sync_service.cpp
  32. file_sync_service.h
  33. framebuffer_service.cpp
  34. get_my_path_darwin.cpp
  35. get_my_path_linux.cpp
  36. jdwp_service.cpp
  37. MODULE_LICENSE_APACHE2
  38. mutex_list.h
  39. NOTICE
  40. OVERVIEW.TXT
  41. protocol.txt
  42. remount_service.cpp
  43. remount_service.h
  44. services.cpp
  45. SERVICES.TXT
  46. set_verity_enable_state_service.cpp
  47. shell_service.cpp
  48. shell_service.h
  49. sockets.cpp
  50. sockets.dia
  51. SYNC.TXT
  52. sysdeps.h
  53. sysdeps_win32.cpp
  54. test_adb.py
  55. test_device.py
  56. test_track_devices.cpp
  57. transport.cpp
  58. transport.h
  59. transport_local.cpp
  60. transport_test.cpp
  61. transport_usb.cpp
  62. usb_linux.cpp
  63. usb_linux_client.cpp
  64. usb_osx.cpp
  65. usb_windows.cpp