Gitiles
Code Review Sign In
review.blissroms.org / platform_packages_modules_adb / e69060b7926415fab2b4432291c61aae129c96ff
commite69060b7926415fab2b4432291c61aae129c96ff[log] [tgz]
authorJosh Gao <jmgao@google.com>Mon Mar 19 13:20:29 2018 -0700
committerJosh Gao <jmgao@google.com>Wed Mar 28 23:36:28 2018 -0700
tree7fda1f9168cec51431cbe2954185980ff76f0c0e
parent58ff0a23d2dacc6986b6a60e43df48ea3eaff1a3 [diff]
adb: don't immediately close a socket when write fails.

When we fail to write to a local socket peer, we might still have data
queued up to send to the other side. Defer closing the socket until
we've failed to both read and write.

Bug: http://b/74616284
Test: python test_device.py
Change-Id: Ifc4b8fe95369b4872e475c2ae4ee611dd2d8b9d7
(cherry picked from commit 4b80850ae52fe0b7006b05518aa04aa623842f0c)
2 files changed
tree: 7fda1f9168cec51431cbe2954185980ff76f0c0e
  1. client/
  2. daemon/
  3. sysdeps/
  4. .clang-format ⇨ ../.clang-format-4
  5. adb.cpp
  6. adb.h
  7. adb_auth.h
  8. adb_auth_host.cpp
  9. adb_client.cpp
  10. adb_client.h
  11. adb_io.cpp
  12. adb_io.h
  13. adb_io_test.cpp
  14. adb_listeners.cpp
  15. adb_listeners.h
  16. adb_listeners_test.cpp
  17. adb_mdns.h
  18. adb_trace.cpp
  19. adb_trace.h
  20. adb_unique_fd.h
  21. adb_utils.cpp
  22. adb_utils.h
  23. adb_utils_test.cpp
  24. adbd_auth.cpp
  25. Android.bp
  26. Android.mk
  27. bugreport.cpp
  28. bugreport.h
  29. bugreport_test.cpp
  30. commandline.cpp
  31. commandline.h
  32. console.cpp
  33. CPPLINT.cfg
  34. diagnose_usb.cpp
  35. diagnose_usb.h
  36. fdevent.cpp
  37. fdevent.h
  38. fdevent_test.cpp
  39. fdevent_test.h
  40. file_sync_client.cpp
  41. file_sync_service.cpp
  42. file_sync_service.h
  43. framebuffer_service.cpp
  44. jdwp_service.cpp
  45. line_printer.cpp
  46. line_printer.h
  47. MODULE_LICENSE_APACHE2
  48. NOTICE
  49. OVERVIEW.TXT
  50. OWNERS
  51. protocol.txt
  52. range.h
  53. remount_service.cpp
  54. remount_service.h
  55. security_log_tags.h
  56. services.cpp
  57. services.h
  58. SERVICES.TXT
  59. set_verity_enable_state_service.cpp
  60. shell_service.cpp
  61. shell_service.h
  62. shell_service_protocol.cpp
  63. shell_service_protocol_test.cpp
  64. shell_service_test.cpp
  65. socket.h
  66. socket_spec.cpp
  67. socket_spec.h
  68. socket_spec_test.cpp
  69. socket_test.cpp
  70. sockets.cpp
  71. sockets.dia
  72. SYNC.TXT
  73. sysdeps.h
  74. sysdeps_test.cpp
  75. sysdeps_unix.cpp
  76. sysdeps_win32.cpp
  77. sysdeps_win32_test.cpp
  78. test_adb.py
  79. test_device.py
  80. trace.sh
  81. transport.cpp
  82. transport.h
  83. transport_local.cpp
  84. transport_mdns.cpp
  85. transport_mdns_unsupported.cpp
  86. transport_test.cpp
  87. transport_usb.cpp
  88. usb.h