commit 758a7562d72b0a6ed336beac508eedf7b369fa20
author Dmitri Plotnikov <dplotnikov@google.com> Mon May 24 11:23:17 2010 -0700
committer Dmitri Plotnikov <dplotnikov@google.com> Mon May 24 11:23:17 2010 -0700
tree eb8e773f330316e9cddad49f4fbb2bb90e6d1a2c
parent 39f93a31c44d75f276f8f6bb7691674a76c7c1de

Cleaning up the contacts DB during upgrade to version 203

Bug: 2709359
Change-Id: I3912e935aba3b5ff40347616843e8caffccacead

src/com/android/providers/contacts/ContactsDatabaseHelper.java

diff --git a/src/com/android/providers/contacts/ContactsDatabaseHelper.java b/src/com/android/providers/contacts/ContactsDatabaseHelper.java
index 6a76a0b..6a5015f 100644
--- a/src/com/android/providers/contacts/ContactsDatabaseHelper.java
+++ b/src/com/android/providers/contacts/ContactsDatabaseHelper.java
@@ -1547,6 +1547,15 @@
     }
 
     private void upgradeToVersion203(SQLiteDatabase db) {
+        // Garbage-collect first. A bug in Eclair was sometimes leaving
+        // raw_contacts in the database that no longer had contacts associated
+        // with them.  To avoid failures during this database upgrade, drop
+        // the orphaned raw_contacts.
+        db.execSQL(
+                "DELETE FROM raw_contacts" +
+                " WHERE contact_id NOT NULL" +
+                " AND contact_id NOT IN (SELECT _id FROM contacts)");
+
         db.execSQL(
                 "ALTER TABLE " + Tables.CONTACTS +
                 " ADD " + Contacts.NAME_RAW_CONTACT_ID + " INTEGER REFERENCES raw_contacts(_id)");