| commit | 785dfe7f17c612326bb7b2dcf67263aaa9b6cca1 | [log] [tgz] |
|---|---|---|
| author | Hall Liu <hallliu@google.com> | Tue Sep 24 18:38:30 2019 -0700 |
| committer | Hall Liu <hallliu@google.com> | Tue Sep 24 18:38:30 2019 -0700 |
| tree | 6953e817ec9575ae323b8ebe0bf85133e8df2714 | |
| parent | 728c412a52719f155e941b41b499e9d9efe8886a [diff] |
Fix race condition in Ringer Race condition is as follows: Initially: mIsVibrating == false Thread 1: mVibrator.vibrate (maybeStartVibration) Thread 2: checks mIsVibrating == false, doesn't bother stopping it Thread 1: sets mVibrating = true Thread 2: *never stops the vibrator* Fix is to set mIsVibrating to true before actually starting the ringer. Fixes: 140013629 Test: manual Change-Id: I1eb0ee02ae54494691499e1c4fbf4dd6ae7760b5