tree 17f9332f8f3b098258faefc0a066d22642b8545d
parent 04f79369f4b17e203ae511c7800e224eb74ff2a5
author Tyler Gunn <tgunn@google.com> 1575657148 -0800
committer Tyler Gunn <tgunn@google.com> 1575657564 -0800

Cleanup connection destruction to avoid ConcurrentModificationException.

disconnectConferenceParticipantshandleConnectionDestruction attempts to
modify the hashmap while looping through it; calling
handleConnectionDestruction is the source of this and can cause a
ConcurrentModificationException.

handleConnectionDestruction just removes the participant from
mConferenceParticipantConnections and destroys it; we're already destroying
it in disconnectConferenceParticipants and we call clear, so we're removing
it.  The only thing left to do is to update the manage conference
property, which we can optimally just do once after we cleared the
connections anyways.  This avoids modifying the HashMap while we are
looping through it.

Test: Run unit tests.
Bug: 145654233
Change-Id: I47bc0d5c93dbf6b5f61c013a9884447d3a9af19c