Promote modernize-pass-by-value to error & fix violations

See:
https://clang.llvm.org/extra/clang-tidy/checks/modernize-pass-by-value.html
https://web.archive.org/web/20140205194657/http://cpp-next.com/archive/2009/08/want-speed-pass-by-value/

Bug: 134590767
Test: m apexd
Test: atest apexservice_test
Test: atest apex_database_test
Test: atest apex_file_test
Test: atest apex_manifest_test
Change-Id: I72d5c8fdf1b588930fec50c3085b480f07e5e6e7
3 files changed
tree: 9e73509f574fd28f61cc29531c30118fd65782de
  1. apexd/
  2. apexer/
  3. docs/
  4. proto/
  5. shim/
  6. tests/
  7. CleanSpec.mk
  8. OWNERS
  9. PREUPLOAD.cfg