| commit | eaa7b9eb3f341410e2e637f90217629d972b32f6 | [log] [tgz] |
|---|---|---|
| author | Maciej Żenczykowski <maze@google.com> | Fri Apr 24 16:40:41 2020 +0000 |
| committer | Maciej Zenczykowski <maze@google.com> | Fri Apr 24 17:16:36 2020 +0000 |
| tree | 206a9ee3254ca45160b6db68fb6ac12cd10391bb | |
| parent | c65b351176ff0cc00cf1ba8a1cad318473a5d055 [diff] |
BpfMap.h - fix cert-oop54-cpp compiler warning
Fixes:
system/bpf/libbpf_android/include/bpf/BpfMap.h:132:10: warning: operator=() does not handle self-assignment properly [cert-oop54-cpp]
void operator=(const BpfMap<Key, Value>& other) {
^
Matches the self-assignment check from
https://clang.llvm.org/extra/clang-tidy/checks/bugprone-unhandled-self-assignment.html
This isn't needed here, since the code was already correct, but
it does prevent a pointless newfd = dup(fd); close(fd); sequence.
Test: builds
Bug: 153035880
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: Ia57f95d4ab180783c97db7e6f8d929f822c8958d
Merged-In: Ia57f95d4ab180783c97db7e6f8d929f822c8958d