Gitiles
Code Review Sign In
review.blissroms.org / platform_system_bt / f107e4f9e841152e5b94fa2f9d68c558d8c1b055
commitf107e4f9e841152e5b94fa2f9d68c558d8c1b055[log] [tgz]
authorJakub Pawlowski <jpawlowski@google.com>Thu Apr 12 05:42:31 2018 -0700
committerJakub Pawlowski <jpawlowski@google.com>Wed Apr 18 07:10:09 2018 +0000
treebbebba7717915687f2df2020d01c3564c6684c37
parenta9575b4fc0f277fe6487c6035700a55d5efcb5b1 [diff]
GATT: fix 32 bit UUID handling

When writing UUID into stream with gatt_build_uuid_to_stream, we always
use 16bit or 128bit representation. In GATT code returning service UUID,
we were returning 32bit representation lenght, even though 128bit
representation was being returned in the stream. This resulted in
invalid GATT database content being returned, and the service not being
visible.

Bug: 66912853
Test: create GATT database with 32bit UUID, discover from remote device
Change-Id: I791a518ab080bd99db0a8be18d97e865c838fc7e
4 files changed
tree: bbebba7717915687f2df2020d01c3564c6684c37
  1. audio_a2dp_hw/
  2. audio_hearing_aid_hw/
  3. binder/
  4. bta/
  5. btcore/
  6. btif/
  7. build/
  8. conf/
  9. device/
  10. doc/
  11. embdrv/
  12. hci/
  13. include/
  14. internal_include/
  15. main/
  16. osi/
  17. packet/
  18. profile/
  19. proto/
  20. service/
  21. stack/
  22. test/
  23. tools/
  24. types/
  25. udrv/
  26. utils/
  27. vendor_libs/
  28. vnd/
  29. .clang-format
  30. .gitignore
  31. .gn
  32. Android.bp
  33. Android.mk
  34. BUILD.gn
  35. CleanSpec.mk
  36. EventLogTags.logtags
  37. MODULE_LICENSE_APACHE2
  38. NOTICE
  39. OWNERS
  40. PREUPLOAD.cfg
  41. README.md
README.md

Fluoride Bluetooth stack

Building and running on AOSP

Just build AOSP - Fluoride is there by default.

Building and running on Linux

Instructions for Ubuntu, tested on 14.04 with Clang 3.5.0 and 16.10 with Clang 3.8.0

Download source

mkdir ~/fluoride
cd ~/fluoride
git clone https://android.googlesource.com/platform/system/bt

Install dependencies (require sudo access):

cd ~/fluoride/bt
build/install_deps.sh

Then fetch third party dependencies:

cd ~/fluoride/bt
mkdir third_party
cd third_party
git clone https://github.com/google/googletest.git
git clone https://android.googlesource.com/platform/external/aac
git clone https://android.googlesource.com/platform/external/libchrome
git clone https://android.googlesource.com/platform/external/libldac
git clone https://android.googlesource.com/platform/external/modp_b64
git clone https://android.googlesource.com/platform/external/tinyxml2

And third party dependencies of third party dependencies:

cd fluoride/bt/third_party/libchrome/base/third_party
mkdir valgrind
cd valgrind
curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/valgrind.h?format=TEXT | base64 -d > valgrind.h
curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/memcheck.h?format=TEXT | base64 -d > memcheck.h

NOTE: If system/bt is checked out under AOSP, then create symbolic links instead of downloading sources

cd system/bt
mkdir third_party
cd third_party
ln -s ../../../external/aac aac
ln -s ../../../external/libchrome libchrome
ln -s ../../../external/libldac libldac
ln -s ../../../external/modp_b64 modp_b64
ln -s ../../../external/tinyxml2 tinyxml2
ln -s ../../../external/googletest googletest

Generate your build files

cd ~/fluoride/bt
gn gen out/Default

Build

cd ~/fluoride/bt
ninja -C out/Default all

This will build all targets (the shared library, executables, tests, etc) and put them in out/Default. To build an individual target, replace "all" with the target of your choice, e.g. ninja -C out/Default net_test_osi.

Run

cd ~/fluoride/bt/out/Default
LD_LIBRARY_PATH=./ ./bluetoothtbd -create-ipc-socket=fluoride

Eclipse IDE Support

  1. Follows the Chromium project Eclipse Setup Instructions until "Optional: Building inside Eclipse" section (don't do that section, we will set it up differently)

  2. Generate Eclipse settings:

cd system/bt
gn gen --ide=eclipse out/Default

  1. In Eclipse, do File->Import->C/C++->C/C++ Project Settings, choose the XML location under system/bt/out/Default

  2. Right click on the project. Go to Preferences->C/C++ Build->Builder Settings. Uncheck "Use default build command", but instead using "ninja -C out/Default"

  3. Goto Behaviour tab, change clean command to "-t clean"