tree f06ee23f679d817c0f6767d5c791b009c9d254ff
parent 51893f20564cb04b1469c17fb9c73e4877ddab0c
author Hans Boehm <hboehm@google.com> 1489600863 -0700
committer Hans Boehm <hboehm@google.com> 1489798048 -0700

Add heuristic data race detection to sp<>

Force assignment to read the old pointer value twice, and check
that it didn't change in the interim. Previous experience with
Skia suggests that this has a high probability of correctly detecting
a data race when it occurs, instead of potentially letting the
count associated with the old pointer value get decremented twice,
and corrupting the heap.

This does increase the size of sp assignments, which seem to
commonly get inlined. For the general case, we add a third
comparison and function call.

Some code reformatting to make this consistent with modern conventions
and pass automated checks.

Test: Booted aosp build. Ran libutils tests. Looked at generated code.

Bug: 31227650

Change-Id: Id93a05c6bf10f01ee15ff1bb409611f2058f988f