tree 1a8b467bf99c86af287d0baae0697126723db08e
parent 55f503e5b3d34110f09b1c727a131a51a687b9b8
author Adrian Salido <salidoa@google.com> 1482277935 -0800
committer Adrian Salido <salidoa@google.com> 1483477889 -0800

init/service.cpp: fix access check for console

Commit 9596d2b95d3137c476be4b7c15c47c62ef5cbe09 changes how
availability of console is checked by only checking access bits for
the console device. However, in cases where there is no console it
defaults to /dev/console. This device is always enumerated by tty
driver (i.e. file and access bits may be correct), but it doesn't
always map to an underlying console driver. Because the lookup for the
underlying console driver happens during the open system call, checking
only the access bits is not sufficient and need to make sure open
system call is successful, we can safely close the FD afterwards to
avoid FD leaks.

Test: boot device and check console svc doesn't continuously restart
Bug: 33691649
Change-Id: Ia51a8a2f56c345b70db55e95f61a057a98b52895