init: -1 log for control message error paths.
Fixes: 140136969
Test: check logs
Change-Id: Id80f59927b44d1026c6e3389c80ca96baf0733c4
diff --git a/init/init.cpp b/init/init.cpp
index cf04a2e..ce898de 100644
--- a/init/init.cpp
+++ b/init/init.cpp
@@ -305,9 +305,6 @@
process_cmdline = "unknown process";
}
- LOG(INFO) << "Received control message '" << msg << "' for '" << name << "' from pid: " << pid
- << " (" << process_cmdline << ")";
-
const ControlMessageFunction& function = it->second;
Service* svc = nullptr;
@@ -320,20 +317,25 @@
svc = ServiceList::GetInstance().FindInterface(name);
break;
default:
- LOG(ERROR) << "Invalid function target from static map key '" << msg << "': "
+ LOG(ERROR) << "Invalid function target from static map key ctl." << msg << ": "
<< static_cast<std::underlying_type<ControlTarget>::type>(function.target);
return false;
}
if (svc == nullptr) {
- LOG(ERROR) << "Could not find '" << name << "' for ctl." << msg;
+ LOG(ERROR) << "Control message: Could not find '" << name << "' for ctl." << msg
+ << " from pid: " << pid << " (" << process_cmdline << ")";
return false;
}
if (auto result = function.action(svc); !result) {
- LOG(ERROR) << "Could not ctl." << msg << " for '" << name << "': " << result.error();
+ LOG(ERROR) << "Control message: Could not ctl." << msg << " for '" << name
+ << "' from pid: " << pid << " (" << process_cmdline << "): " << result.error();
return false;
}
+
+ LOG(INFO) << "Control message: Processed ctl." << msg << " for '" << name
+ << "' from pid: " << pid << " (" << process_cmdline << ")";
return true;
}