commit 008efb756fea8a9e66a1825b546e9dc392c72bec
author Elliott Hughes <enh@google.com> Tue Apr 19 14:57:09 2016 -0700
committer Elliott Hughes <enh@google.com> Tue Apr 19 14:57:09 2016 -0700
tree dbd6fd427fe2073c73bc8fc946b3e0f0606731d1
parent 6ea6c04ca695e0f0b6bcf3ea4529b9fd74fee8e4

Fix scanf %s in lsof.

Bug: http://b/28175237
Change-Id: Ief0ba299b09693ad9afc0e3d17a8f664c2fbb8c2

toolbox/lsof.c

diff --git a/toolbox/lsof.c b/toolbox/lsof.c
index 113c120..de197a2 100644
--- a/toolbox/lsof.c
+++ b/toolbox/lsof.c
@@ -99,13 +99,12 @@
 static void print_maps(struct pid_info_t* info)
 {
     FILE *maps;
-    char buffer[PATH_MAX + 100];
 
     size_t offset;
     int major, minor;
     char device[10];
     long int inode;
-    char file[PATH_MAX];
+    char file[1024];
 
     strlcat(info->path, "maps", sizeof(info->path));
 
@@ -113,8 +112,8 @@
     if (!maps)
         goto out;
 
-    while (fscanf(maps, "%*x-%*x %*s %zx %5s %ld %s\n", &offset, device, &inode,
-            file) == 4) {
+    while (fscanf(maps, "%*x-%*x %*s %zx %5s %ld %1023s\n",
+                  &offset, device, &inode, file) == 4) {
         // We don't care about non-file maps
         if (inode == 0 || !strcmp(device, "00:00"))
             continue;