commit 0b6e7ec079abace79067f62fd359e72050e575af
author George Burgess IV <gbiv@google.com> Wed Oct 02 11:22:55 2019 -0700
committer Suren Baghdasaryan <surenb@google.com> Wed Oct 02 19:55:41 2019 +0000
tree c68ac1b4fb510ff2219ea9a46c713fb5b3cef2e2
parent 01753232ee2a5dfd8553d33a18bbf514d7f668dd

lmkd: fix an uninit value bug

Caught by clang's static analyzer:
system/core/lmkd/lmkd.c:930:9: warning: 1st function call argument is an
uninitialized value [clang-analyzer-core.CallAndMessage]

Bug: None
Test: TreeHugger
Change-Id: I9dc8e97d6aa22ea977fa06553d957a31a9df8819

lmkd/lmkd.c

diff --git a/lmkd/lmkd.c b/lmkd/lmkd.c
index e3f2bc2..372e10f 100644
--- a/lmkd/lmkd.c
+++ b/lmkd/lmkd.c
@@ -926,12 +926,12 @@
 static void cmd_procremove(LMKD_CTRL_PACKET packet) {
     struct lmk_procremove params;
 
+    lmkd_pack_get_procremove(packet, &params);
     if (use_inkernel_interface) {
         stats_remove_taskname(params.pid, kpoll_info.poll_fd);
         return;
     }
 
-    lmkd_pack_get_procremove(packet, &params);
     /*
      * WARNING: After pid_remove() procp is freed and can't be used!
      * Therefore placed at the end of the function.