Cleanup ziparchive
Addressed review comments from 8e08536108d2b5a7f4f9a4b008987b54602fda18
Change-Id: If576e2d6cc5ad330a7dee66b09663e0c04ea3801
diff --git a/libziparchive/zip_archive.cc b/libziparchive/zip_archive.cc
index 24088bb..5f9dc8d 100644
--- a/libziparchive/zip_archive.cc
+++ b/libziparchive/zip_archive.cc
@@ -888,6 +888,8 @@
struct IterationHandle {
uint32_t position;
+ // We're not using vector here because this code is used in the Windows SDK
+ // where the STL is not available.
const uint8_t* prefix;
uint16_t prefix_len;
ZipArchive* archive;
@@ -897,13 +899,12 @@
IterationHandle(const ZipEntryName& prefix_name)
: prefix_len(prefix_name.name_length) {
uint8_t* prefix_copy = new uint8_t[prefix_len];
- memcpy(reinterpret_cast<void*>(prefix_copy), prefix_name.name,
- prefix_len * sizeof(uint8_t));
+ memcpy(prefix_copy, prefix_name.name, prefix_len);
prefix = prefix_copy;
}
~IterationHandle() {
- delete [] prefix;
+ delete[] prefix;
}
};