commit 1b73ae7dc775e857640c372a37ecdc4f2df84833
author Ting-Yuan Huang <laszio@google.com> Wed Aug 30 03:23:23 2017 +0000
committer android-build-merger <android-build-merger@google.com> Wed Aug 30 03:23:23 2017 +0000
tree b60824f731534567fc22dc4355e8a1829367a49c
parent 94b35abd9fd776ece155e16d2a9d03d6329d105a
parent 25196f7284ef255738123558cf50895a3f51ab04

Merge "sdcard: mute false compiler alarm" am: cb4e164562 am: 124294a348 am: e657bf552c
am: 9cd73e43ed

Change-Id: Ic80193f847e4b8c8700f27b251dbf8cd5cb9d316

sdcard/sdcard.cpp

diff --git a/sdcard/sdcard.cpp b/sdcard/sdcard.cpp
index c342cf8..343a903 100644
--- a/sdcard/sdcard.cpp
+++ b/sdcard/sdcard.cpp
@@ -249,7 +249,9 @@
     global.root.uid = AID_ROOT;
     global.root.under_android = false;
 
-    strcpy(global.source_path, source_path);
+    // Clang static analyzer think strcpy potentially overwrites other fields
+    // in global. Use snprintf() to mute the false warning.
+    snprintf(global.source_path, sizeof(global.source_path), "%s", source_path);
 
     if (multi_user) {
         global.root.perm = PERM_PRE_ROOT;