commit 1d0d86efa97da2db8d8340d8ae0c5cdcd9d875f5
author Josh Gao <jmgao@google.com> Mon Jul 08 17:57:30 2019 -0700
committer Josh Gao <jmgao@google.com> Mon Jul 08 18:05:55 2019 -0700
tree c25e3744c7021710b4e14a434e5b933fcc7ab74a
parent b11eb64f6a9bdd6972f8f8be70c68298b43f3135

adb: fdevent: delete FDE_CREATED.

All fdevents must be created by fdevent_create/fdevent_context::Create
now, so this flag is meaningless.

Test: none
Change-Id: I8489afad07bdb267ddfdb0dbb25d40d3a62f55f6

adb/fdevent/fdevent.cpp

diff --git a/adb/fdevent/fdevent.cpp b/adb/fdevent/fdevent.cpp
index c858f6b..d6e3a66 100644
--- a/adb/fdevent/fdevent.cpp
+++ b/adb/fdevent/fdevent.cpp
@@ -33,9 +33,6 @@
     if (fde->state & FDE_PENDING) {
         state += "P";
     }
-    if (fde->state & FDE_CREATED) {
-        state += "C";
-    }
     if (fde->state & FDE_READ) {
         state += "R";
     }

adb/fdevent/fdevent.h

diff --git a/adb/fdevent/fdevent.h b/adb/fdevent/fdevent.h
index 5a2f2c6..0147ad5 100644
--- a/adb/fdevent/fdevent.h
+++ b/adb/fdevent/fdevent.h
@@ -43,7 +43,6 @@
 
 #define FDE_ACTIVE     0x0100
 #define FDE_PENDING    0x0200
-#define FDE_CREATED    0x0400
 
 typedef void (*fd_func)(int fd, unsigned events, void *userdata);
 typedef void (*fd_func2)(struct fdevent* fde, unsigned events, void* userdata);

adb/fdevent/fdevent_poll.cpp

diff --git a/adb/fdevent/fdevent_poll.cpp b/adb/fdevent/fdevent_poll.cpp
index 7615859..f786337 100644
--- a/adb/fdevent/fdevent_poll.cpp
+++ b/adb/fdevent/fdevent_poll.cpp
@@ -105,7 +105,6 @@
     auto pair = poll_node_map_.emplace(fde->fd.get(), PollNode(fde));
     CHECK(pair.second) << "install existing fd " << fde->fd.get();
 
-    fde->state |= FDE_CREATED;
     return fde;
 }
 
@@ -115,10 +114,6 @@
         return {};
     }
 
-    if (!(fde->state & FDE_CREATED)) {
-        LOG(FATAL) << "destroying fde not created by fdevent_create(): " << dump_fde(fde);
-    }
-
     unique_fd result = std::move(fde->fd);
     if (fde->state & FDE_ACTIVE) {
         poll_node_map_.erase(result.get());