commit 239605ef64d34ced82c97870e3f3f5c4145be58c
author Greg Hackmann <ghackmann@google.com> Sun Apr 06 21:25:58 2014 -0700
committer Greg Hackmann <ghackmann@google.com> Mon Apr 07 15:17:30 2014 -0700
tree 0e3b255dab39309d8351535b3ae94e9c66c9c874
parent 223fc42b5e289e882f67c893374ffbef595a6901

logd: fix LogStatistics::format freeing wrong pointer

Fixes a leak and use-after-free if a client passes in an
already-allocated target buffer (currently none do)

Change-Id: Ie20c30bd5ba31e1b6db73885bd9d2ebd7e40dc27
Signed-off-by: Greg Hackmann <ghackmann@google.com>

logd/LogStatistics.cpp

diff --git a/logd/LogStatistics.cpp b/logd/LogStatistics.cpp
index 5622ee5..88414d9 100644
--- a/logd/LogStatistics.cpp
+++ b/logd/LogStatistics.cpp
@@ -401,7 +401,7 @@
     const unsigned short spaces_total = 19;
 
     if (*buf) {
-        free(buf);
+        free(*buf);
         *buf = NULL;
     }