commit 2c852f5b373ed20f9de482b1c49ae6ea9447daa7
author Lorenzo Colitti <lorenzo@google.com> Wed Apr 10 12:01:34 2019 +0900
committer Maciej Żenczykowski <maze@google.com> Wed May 08 21:02:57 2019 -0700
tree 6d9bc50d58b60aa7ecc97cc1939952f198d237ec
parent bb3d02b8bd0bcb0b57a3db66f0ac62a1d9a3178d

Make the SocketListener control pipe O_CLOEXEC.

Children of processes that use SocketListener should not be able
to stop the SocketListener.

Test: builds, boots
Test: atest libsysutils_tests
Test: atest --test-mapping system/netd
Bug: 131268436
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I64898d9966f62004468b8e8a43b59be4a81a8cc4
Merged-In: I64898d9966f62004468b8e8a43b59be4a81a8cc4
(cherry picked from commit dae0195380686dbec450e298f4acf47b5f9576e6)

libsysutils/src/SocketListener.cpp

diff --git a/libsysutils/src/SocketListener.cpp b/libsysutils/src/SocketListener.cpp
index ded5adb..9780606 100644
--- a/libsysutils/src/SocketListener.cpp
+++ b/libsysutils/src/SocketListener.cpp
@@ -95,7 +95,7 @@
     } else if (!mListen)
         mClients[mSock] = new SocketClient(mSock, false, mUseCmdNum);
 
-    if (pipe(mCtrlPipe)) {
+    if (pipe2(mCtrlPipe, O_CLOEXEC)) {
         SLOGE("pipe failed (%s)", strerror(errno));
         return -1;
     }