Gitiles
Code Review Sign In
review.blissroms.org / platform_system_core_old / 37fc0a5ce698ede8d7792c5f813d1c3b2c6d4fbf
commit37fc0a5ce698ede8d7792c5f813d1c3b2c6d4fbf[log] [tgz]
authorGeorge Burgess IV <gbiv@google.com>Tue May 15 18:56:36 2018 -0700
committerGeorge Burgess IV <gbiv@google.com>Wed May 16 03:06:59 2018 +0000
treea7761a23e2a70a824d4a48af19061d5810fe090f
parent262fd9a563404d18478f5aa6e676f6ac2339feef [diff]
Simplify code

The static analyzer is concerned about the strcpys below this, since it
apparently doesn't try to model snprintf's potential behaviors. (In
particular, it was concerned that suffixLen might be >=
sizeof(suffixBuf)). While that's clearly suboptimal, this code can also
be simplified to make it more obvious what's happening and to appease
the analyzer.

No functionality change is intended.

Bug: None
Test: Ran the analyzer. It's no longer angry about strcpy overflows.

Change-Id: I4aa812144c90f6d3e833bbcb23c0694476a0e53e
1 file changed
tree: a7761a23e2a70a824d4a48af19061d5810fe090f
  1. adb/
  2. adf/
  3. base/
  4. bootstat/
  5. cpio/
  6. debuggerd/
  7. demangle/
  8. diagnose_usb/
  9. fastboot/
  10. fs_mgr/
  11. gatekeeperd/
  12. healthd/
  13. include/
  14. init/
  15. libappfuse/
  16. libasyncio/
  17. libbacktrace/
  18. libbinderwrapper/
  19. libcrypto_utils/
  20. libcutils/
  21. libdiskconfig/
  22. libgrallocusage/
  23. libion/
  24. libkeyutils/
  25. liblog/
  26. libmemtrack/
  27. libmemunreachable/
  28. libmetricslogger/
  29. libnativebridge/
  30. libnativeloader/
  31. libnetutils/
  32. libpackagelistparser/
  33. libpixelflinger/
  34. libprocessgroup/
  35. libprocinfo/
  36. libqtaguid/
  37. libsparse/
  38. libsuspend/
  39. libsync/
  40. libsystem/
  41. libsysutils/
  42. libunwindstack/
  43. libusbhost/
  44. libutils/
  45. libvndksupport/
  46. libziparchive/
  47. llkd/
  48. lmkd/
  49. logcat/
  50. logd/
  51. logwrapper/
  52. mkbootimg/
  53. property_service/
  54. qemu_pipe/
  55. reboot/
  56. rootdir/
  57. run-as/
  58. sdcard/
  59. shell_and_utilities/
  60. storaged/
  61. toolbox/
  62. trusty/
  63. usbd/
  64. .clang-format ⇨ .clang-format-4
  65. .clang-format-2
  66. .clang-format-4
  67. .gitignore
  68. Android.bp
  69. Android.mk
  70. CleanSpec.mk
  71. MODULE_LICENSE_APACHE2
  72. NOTICE
  73. OWNERS
  74. platform_tools_tool_version.mk
  75. PREUPLOAD.cfg